fixup, go mod tidy -diff not yet implemented #3
code-quality.yaml
on: push
golangci-lint (components/notebook-controller)
1m 17s
golangci-lint (components/odh-notebook-controller)
1m 11s
Annotations
41 errors
golangci-lint (components/odh-notebook-controller)
Process completed with exit code 1.
|
golangci-lint (components/odh-notebook-controller)
controllers.SetContainerImageFromRegistry calls dynamic.NewForConfig, which eventually calls http2.ConfigureTransports
|
golangci-lint (components/odh-notebook-controller)
controllers.NotebookWebhook.Handle calls admission.Errored, which calls http2.ConnectionError.Error
|
golangci-lint (components/odh-notebook-controller)
controllers.NotebookWebhook.Handle calls fmt.Sprintf, which eventually calls http2.ErrCode.String
|
golangci-lint (components/odh-notebook-controller)
controllers.NotebookWebhook.Handle calls fmt.Sprintf, which eventually calls http2.FrameHeader.String
|
golangci-lint (components/odh-notebook-controller)
controllers.NotebookWebhook.Handle calls fmt.Sprintf, which eventually calls http2.FrameType.String
|
golangci-lint (components/odh-notebook-controller)
controllers.NotebookWebhook.Handle calls admission.Errored, which calls http2.GoAwayError.Error
|
golangci-lint (components/odh-notebook-controller)
controllers.NotebookWebhook.Handle calls fmt.Sprintf, which eventually calls http2.Setting.String
|
golangci-lint (components/odh-notebook-controller)
controllers.NotebookWebhook.Handle calls fmt.Sprintf, which eventually calls http2.SettingID.String
|
golangci-lint (components/odh-notebook-controller)
controllers.NotebookWebhook.Handle calls admission.Errored, which calls http2.StreamError.Error
|
golangci-lint (components/odh-notebook-controller)
controllers.SetContainerImageFromRegistry calls dynamic.dynamicResourceClient.List, which eventually calls http2.Transport.NewClientConn
|
golangci-lint (components/odh-notebook-controller):
components/odh-notebook-controller/e2e/helper_test.go#L24
SA1019: wait.Poll is deprecated: This method does not return errors from context, use PollWithContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
|
golangci-lint (components/odh-notebook-controller):
components/odh-notebook-controller/e2e/helper_test.go#L60
SA1019: wait.Poll is deprecated: This method does not return errors from context, use PollWithContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
|
golangci-lint (components/odh-notebook-controller):
components/odh-notebook-controller/e2e/helper_test.go#L79
SA1019: wait.Poll is deprecated: This method does not return errors from context, use PollWithContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
|
golangci-lint (components/odh-notebook-controller):
components/odh-notebook-controller/e2e/notebook_creation_test.go#L142
SA4009: argument err is overwritten before first use (staticcheck)
|
golangci-lint (components/odh-notebook-controller):
components/odh-notebook-controller/e2e/notebook_creation_test.go#L144
SA4009(related information): assignment to err (staticcheck)
|
golangci-lint (components/odh-notebook-controller):
components/odh-notebook-controller/controllers/notebook_controller.go#L116
Error return value of `retry.OnError` is not checked (errcheck)
|
golangci-lint (components/odh-notebook-controller):
components/odh-notebook-controller/controllers/notebook_oauth.go#L190
Error return value of `rand.Read` is not checked (errcheck)
|
golangci-lint (components/odh-notebook-controller):
components/odh-notebook-controller/controllers/suite_test.go#L57
var `cfg` is unused (unused)
|
golangci-lint (components/odh-notebook-controller):
components/odh-notebook-controller/controllers/suite_test.go#L66
const `timeout` is unused (unused)
|
golangci-lint (components/odh-notebook-controller):
components/odh-notebook-controller/controllers/suite_test.go#L67
const `interval` is unused (unused)
|
golangci-lint (components/notebook-controller):
components/notebook-controller/api/v1beta1/notebook_webhook.go#L24
var `notebooklog` is unused (unused)
|
golangci-lint (components/notebook-controller):
components/notebook-controller/pkg/culler/culler.go#L325
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.KernelStatus is defined as zero (gosimple)
|
golangci-lint (components/notebook-controller):
components/notebook-controller/pkg/culler/culler.go#L362
S1009: should omit nil check; len() for []github.com/kubeflow/kubeflow/components/notebook-controller/pkg/culler.TerminalStatus is defined as zero (gosimple)
|
golangci-lint (components/notebook-controller):
components/notebook-controller/pkg/culler/culler.go#L137
S1033: unnecessary guard around call to delete (gosimple)
|
golangci-lint (components/notebook-controller):
components/notebook-controller/pkg/culler/culler.go#L346
S1039: unnecessary use of fmt.Sprintf (gosimple)
|
golangci-lint (components/notebook-controller):
components/notebook-controller/pkg/culler/culler.go#L373
S1039: unnecessary use of fmt.Sprintf (gosimple)
|
golangci-lint (components/notebook-controller):
components/notebook-controller/pkg/culler/culler.go#L266
SA5011: possible nil pointer dereference (staticcheck)
|
golangci-lint (components/notebook-controller):
components/notebook-controller/pkg/culler/culler.go#L267
SA5011(related information): this check suggests that the pointer can be nil (staticcheck)
|
golangci-lint (components/notebook-controller):
components/notebook-controller/controllers/culling_controller_test.go#L256
Error return value is not checked (errcheck)
|
golangci-lint (components/notebook-controller):
components/notebook-controller/controllers/suite_test.go#L43
var `cfg` is unused (unused)
|
golangci-lint (components/notebook-controller)
notebook.main calls manager.New, which eventually calls http2.ConfigureTransports
|
golangci-lint (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.ConnectionError.Error
|
golangci-lint (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.ErrCode.String
|
golangci-lint (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.FrameHeader.String
|
golangci-lint (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.FrameType.String
|
golangci-lint (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.GoAwayError.Error
|
golangci-lint (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.Setting.String
|
golangci-lint (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.SettingID.String
|
golangci-lint (components/notebook-controller)
culler.UpdateNotebookLastActivityAnnotation calls fmt.Sprintf, which eventually calls http2.StreamError.Error
|
golangci-lint (components/notebook-controller)
culler.getNotebookResourceResponse calls http.Client.Get, which eventually calls http2.Transport.NewClientConn
|