Minor changes #183
Draft
Minor changes #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line 36 mctype7,BI0:7,0=inactive;1=mixer;2=fixed;3=hwc;4=returnincr;5=pool;6=unknown,,mixer type
line 36 mctype7,BI0:7,0=inactive;1=mixer;2=fixed;3=hwc;4=returnincr;5=pool;6=unknown,,Mischer Typ
Edited TimeBetweenTwoCompStartsMin comment to make embedded double quotes double double-quotes to enable Python csv to parse it correctly see john30/ebusd#351
Edited TimeBetweenTwoCompStartsMin comment to make embedded double quotes double double-quotes to enable Python csv to parse it correctly see john30/ebusd#351 line 177
john30
requested changes
Sep 20, 2020
| @@ -174,7 +174,7 @@ r,,HwcModeFulfilledHours,DHW_Mode_Fulfilled_Hours,,,,"A700",,,hoursum,,,total ti | |||
| r,,CompState,CompressorState,,,,"E400",,,UCH,,,compressor and ICL state machine status number | |||
| r,,TimeCompOnMin,MinTimeCompressorOn,,,,"E600",,,seconds,,,"minimum time that compressor must run in 0,5s steps" | |||
| r,,TimeCompOffMin,MinTimeCompressorOff,,,,"E700",,,seconds,,,"minimum time the compressor must be off before restart in 0,5s steps" | |||
| r,,TimeBetweenTwoCompStartsMin,Min. Pausenzeit Kompressor,,,,"E800",,,seconds,,,"calculated from menu item ""compressor starts per hour"" in 0,5s steps" | |||
| r,,TimeBetweenTwoCompStartsMin,Min. Pausenzeit Kompressor,,,,"E800",,,seconds,,,"calculated from menu item """"compressor starts per hour"""" in 0,5s steps" | |||
There was a problem hiding this comment.
double double escaping just because some client can't parse it?
I can't accept this
There was a problem hiding this comment.
OK - it was merely a quick and easy suggestion to solve issue #351.
I notice that you've added an enhancement tag to my other suggestion - thanks for that.
There was a problem hiding this comment.
solved with 02d2845, so please remove these lines from de+en
| @@ -174,7 +174,7 @@ r,,HwcModeFulfilledHours,DHW_Mode_Fulfilled_Hours,,,,"A700",,,hoursum,,,total ti | |||
| r,,CompState,CompressorState,,,,"E400",,,UCH,,,compressor and ICL state machine status number | |||
| r,,TimeCompOnMin,MinTimeCompressorOn,,,,"E600",,,seconds,,,"minimum time that compressor must run in 0,5s steps" | |||
| r,,TimeCompOffMin,MinTimeCompressorOff,,,,"E700",,,seconds,,,"minimum time the compressor must be off before restart in 0,5s steps" | |||
| r,,TimeBetweenTwoCompStartsMin,MinTimeBetweenTwoCompressorStarts,,,,"E800",,,seconds,,,"calculated from menu item ""compressor starts per hour"" in 0,5s steps" | |||
| r,,TimeBetweenTwoCompStartsMin,MinTimeBetweenTwoCompressorStarts,,,,"E800",,,seconds,,,"calculated from menu item """"compressor starts per hour"""" in 0,5s steps" | |||
john30
requested changes
Feb 14, 2021
| @@ -174,7 +174,7 @@ r,,HwcModeFulfilledHours,DHW_Mode_Fulfilled_Hours,,,,"A700",,,hoursum,,,total ti | |||
| r,,CompState,CompressorState,,,,"E400",,,UCH,,,compressor and ICL state machine status number | |||
| r,,TimeCompOnMin,MinTimeCompressorOn,,,,"E600",,,seconds,,,"minimum time that compressor must run in 0,5s steps" | |||
| r,,TimeCompOffMin,MinTimeCompressorOff,,,,"E700",,,seconds,,,"minimum time the compressor must be off before restart in 0,5s steps" | |||
| r,,TimeBetweenTwoCompStartsMin,Min. Pausenzeit Kompressor,,,,"E800",,,seconds,,,"calculated from menu item ""compressor starts per hour"" in 0,5s steps" | |||
| r,,TimeBetweenTwoCompStartsMin,Min. Pausenzeit Kompressor,,,,"E800",,,seconds,,,"calculated from menu item """"compressor starts per hour"""" in 0,5s steps" | |||
There was a problem hiding this comment.
solved with 02d2845, so please remove these lines from de+en
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing option 6=unknown on mctype7 (see #182)
Fixes and Python parsing of find -f -c ehp TimeBetweenTwoCompStartsMin embedded double quote problem (see john30/ebusd#351)