Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes #183

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Minor changes #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b689cb
Added 6=unknown to mctype7
HLFCode Jun 7, 2020
621bf5f
added 6=unknown to mctype7
HLFCode Jun 7, 2020
486a6c6
Added double double-quotes to comment
HLFCode Jun 7, 2020
040c0fe
Added double double-quotes to comment
HLFCode Jun 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ebusd-2.1.x/de/vaillant/08.ehp.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ r,,HwcModeFulfilledHours,DHW_Mode_Fulfilled_Hours,,,,"A700",,,hoursum,,,total ti
r,,CompState,CompressorState,,,,"E400",,,UCH,,,compressor and ICL state machine status number
r,,TimeCompOnMin,MinTimeCompressorOn,,,,"E600",,,seconds,,,"minimum time that compressor must run in 0,5s steps"
r,,TimeCompOffMin,MinTimeCompressorOff,,,,"E700",,,seconds,,,"minimum time the compressor must be off before restart in 0,5s steps"
r,,TimeBetweenTwoCompStartsMin,Min. Pausenzeit Kompressor,,,,"E800",,,seconds,,,"calculated from menu item ""compressor starts per hour"" in 0,5s steps"
r,,TimeBetweenTwoCompStartsMin,Min. Pausenzeit Kompressor,,,,"E800",,,seconds,,,"calculated from menu item """"compressor starts per hour"""" in 0,5s steps"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double double escaping just because some client can't parse it?
I can't accept this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - it was merely a quick and easy suggestion to solve issue #351.
I notice that you've added an enhancement tag to my other suggestion - thanks for that.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved with 02d2845, so please remove these lines from de+en

r,,CompControlState,CompressorControlState,,,,"E900",,,UCH,,,number of status of compressor control state machine
r,,RebootCounter,RebootCounter,,,,"F500",,,UIN,,,number of appliance starts
r,,T19MaxToCompOff,T19_Max_To_Compressor_Off,,,,"2B01",,,temp,,,limit on compressor outlet temp that leads to an overpressure situation
Expand Down
2 changes: 1 addition & 1 deletion ebusd-2.1.x/de/vaillant/_templates.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ hcmode,UCH,0=auto;1=off;2=heat;2=water,,Boiler Modus
hcmode2,UCH,0=off;3=heat;4=water,,Boiler Modus
mcmode,UCH,0=disabled;1=on;2=off;3=auto;4=eco;5=low,,Mischer Modus
mctype,UCH,0=inactive;1=mixer;2=fixed;3=hwc;4=returnincr;5=pool,,Mischer Typ
mctype7,BI0:7,0=inactive;1=mixer;2=fixed;3=hwc;4=returnincr;5=pool,,Mischer Typ
mctype7,BI0:7,0=inactive;1=mixer;2=fixed;3=hwc;4=returnincr;5=pool;6=unknown,,Mischer Typ
hwcmode,UCH,0=disabled;1=on;2=off;3=auto,,Warmwasser Modus
hwcmode2,UCH,0=off;1=on;2=auto;3=manual,,Warmwasser Modus
mixer,UCH,0=off;1=open;2=close,,Mixer Status
Expand Down
2 changes: 1 addition & 1 deletion ebusd-2.1.x/en/vaillant/08.ehp.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ r,,HwcModeFulfilledHours,DHW_Mode_Fulfilled_Hours,,,,"A700",,,hoursum,,,total ti
r,,CompState,CompressorState,,,,"E400",,,UCH,,,compressor and ICL state machine status number
r,,TimeCompOnMin,MinTimeCompressorOn,,,,"E600",,,seconds,,,"minimum time that compressor must run in 0,5s steps"
r,,TimeCompOffMin,MinTimeCompressorOff,,,,"E700",,,seconds,,,"minimum time the compressor must be off before restart in 0,5s steps"
r,,TimeBetweenTwoCompStartsMin,MinTimeBetweenTwoCompressorStarts,,,,"E800",,,seconds,,,"calculated from menu item ""compressor starts per hour"" in 0,5s steps"
r,,TimeBetweenTwoCompStartsMin,MinTimeBetweenTwoCompressorStarts,,,,"E800",,,seconds,,,"calculated from menu item """"compressor starts per hour"""" in 0,5s steps"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

r,,CompControlState,CompressorControlState,,,,"E900",,,UCH,,,number of status of compressor control state machine
r,,RebootCounter,RebootCounter,,,,"F500",,,UIN,,,number of appliance starts
r,,T19MaxToCompOff,T19_Max_To_Compressor_Off,,,,"2B01",,,temp,,,limit on compressor outlet temp that leads to an overpressure situation
Expand Down
2 changes: 1 addition & 1 deletion ebusd-2.1.x/en/vaillant/_templates.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ hcmode,UCH,0=auto;1=off;2=heat;2=water,,boiler mode
hcmode2,UCH,0=off;3=heat;4=water,,boiler mode
mcmode,UCH,0=disabled;1=on;2=off;3=auto;4=eco;5=low,,mixer mode
mctype,UCH,0=inactive;1=mixer;2=fixed;3=hwc;4=returnincr;5=pool,,mixer type
mctype7,BI0:7,0=inactive;1=mixer;2=fixed;3=hwc;4=returnincr;5=pool,,mixer type
mctype7,BI0:7,0=inactive;1=mixer;2=fixed;3=hwc;4=returnincr;5=pool;6=unknown,,mixer type
hwcmode,UCH,0=disabled;1=on;2=off;3=auto,,hot water mode
hwcmode2,UCH,0=off;1=on;2=auto;3=manual,,hot water mode
mixer,UCH,0=off;1=open;2=close,,mixer State
Expand Down