Merged
Conversation
jrincayc
reviewed
Apr 20, 2025
wxTerminal.cpp
Outdated
| //If the key event has control or alt pressed, let something else handle it | ||
| //If the key event has control or alt pressed, let something else handle it | ||
| int modCode = (int) event.GetModifiers(); | ||
| if((modCode == wxMOD_ALT) || (modCode == wxMOD_CONTROL)) { |
Owner
There was a problem hiding this comment.
Hm, we use shift with some control functions, so should this be:
if((modCode == wxMOD_ALT) || (modCode == wxMOD_CONTROL) || (modCode == (wxMOD_CONTROL | wxMOD_SHIFT)))
Owner
There was a problem hiding this comment.
Or another possibility (that I have not tested) is to filter out wxMOD_ALTGR :
if(event.HasModifiers() && event.getModifiers() != wxMOD_ALTGR)
Owner
There was a problem hiding this comment.
Basically, the submitted pull request breaks Ctrl++ since that needs shift and control, so please fix, and then I can merge this. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #216