Skip to content

Enable AltGr in wxTerminal. #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrincayc merged 2 commits into from
Apr 28, 2025
Merged

Enable AltGr in wxTerminal. #218

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27936d7
Disable buggy part in configure, enable AltGr in wxTerminal.
Apr 2, 2025
a68cc8d
Fixup previous patch.
jrincayc Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions wxTerminal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,11 +1156,13 @@ extern "C" void do_keyact(int);
void
wxTerminal::OnChar(wxKeyEvent& event)
{
if(event.HasModifiers()) {
//If the key event has control or alt pressed, let something else handle it
//If the key event has control or alt pressed, let something else handle it
int modCode = (int) event.GetModifiers();
if((modCode == wxMOD_ALT) || (modCode == wxMOD_CONTROL)) {
Copy link
Owner

@jrincayc jrincayc Apr 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, we use shift with some control functions, so should this be:
if((modCode == wxMOD_ALT) || (modCode == wxMOD_CONTROL) || (modCode == (wxMOD_CONTROL | wxMOD_SHIFT)))

Copy link
Owner

@jrincayc jrincayc Apr 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or another possibility (that I have not tested) is to filter out wxMOD_ALTGR :
if(event.HasModifiers() && event.getModifiers() != wxMOD_ALTGR)

Copy link
Owner

@jrincayc jrincayc Apr 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, the submitted pull request breaks Ctrl++ since that needs shift and control, so please fix, and then I can merge this. Thanks.

Copy link
Owner

@jrincayc jrincayc Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed myself.

event.Skip();
return;
}

ClearSelection();
int
keyCode = 0,
Expand Down