Scroll to cell by ID based on hash fragment

[krassowski]

References

Reference implementation for jupyter/nbformat#317.

Fixes a 4.0-only regression in jumping to headings which had CSS-escapeable characters.

Closes #12928.

Code changes

• setFragment is now always called for notebook on route change, whether in full windowing mode or not
• removes CSS.escape which was no longer correct and breaking jumping to headings with characters that would be escaped (it was useful back then when we were using querySelector, see Allow cross-file anchors with leading number #11517, but not since we migrated to manual searching for heading in Windowed (Virtual) notebook #12554)

User-facing changes

• Links to #cell-id=my-cell-id will scroll to the cell with such an id.

Backwards-incompatible changes

Links to headings starting with cell id= will now need to be updated with heading= prefix (I don't think there are many headings like that used in the wild).

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[fcollonval]

Thanks @krassowski

Would you mind adding some information in the documentation about this?

[krassowski]

Good point. Documentation added, ready for another round of review/merge.

[fcollonval]

Thanks a lot @krassowski

The cell properties side panel snapshot is not sized correctly when updated.

Lately we are having again side panel sizing flakiness 😢 I think this is linked to #13037 that changes the workspace restoration logic.

[krassowski]

please update documentation snapshots

[fcollonval]

Kicking the CI

[fcollonval]

Thanks @krassowski for making the test more robust.

I saw that there is a regression on galata/test/documentation/debugger.test.ts-snapshots/debugger-variables-documentation-linux.png

[krassowski]

I did not find a quick way to improve that one, so just reverted the assets. The visual tests are passing now but js-services are failing - looks unrelated at first glance?

[fcollonval]

looks unrelated at first glance?

I confirm this is not related.

Thanks Mike - merging now.