Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll to cell by ID based on hash fragment #13285

Merged
merged 15 commits into from
Nov 14, 2022
Merged

Scroll to cell by ID based on hash fragment #13285

merged 15 commits into from
Nov 14, 2022

Commits on Nov 5, 2022

  1. Scroll to cell by ID based on hash fragment

    @krassowski
    krassowski committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    cccdc53 View commit details
    Browse the repository at this point in the history

  2. Preserve the old behaviour for unmatched headings

    @krassowski
    krassowski committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    4c0684a View commit details
    Browse the repository at this point in the history

  3. Add test for scroll to heading/cell, remove CSS.escape. 

    `CSS.escape` was no longer correct since the rewrite to manual
iteration over cells to fetch headings, since we no longer use
`querySelector` and instead compare to actual heading IDs.
    @krassowski
    krassowski committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    1b4cc8f View commit details
    Browse the repository at this point in the history

  4. Document scrolling to notebook headings/cells, change cursor

    @krassowski
    krassowski committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    dc8289d View commit details
    Browse the repository at this point in the history

  5. Update Playwright Snapshots

    @krassowski
    krassowski committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    cef43e1 View commit details
    Browse the repository at this point in the history

  6. Shorten section title, fix image address and code highlight

    @krassowski
    krassowski committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    2d03092 View commit details
    Browse the repository at this point in the history

  7. Prevent kernel flicker on documentation screenshots

    @krassowski
    krassowski committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    ca07960 View commit details
    Browse the repository at this point in the history

  8. Adjust documentation snapshots to new cursor, add positionMouseOver… 

    … utility
    @krassowski
    krassowski committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    f0282b3 View commit details
    Browse the repository at this point in the history

  9. Export added interface, set to empty object by default

    @krassowski
    krassowski committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    9388e26 View commit details
    Browse the repository at this point in the history

  10. Update Playwright Snapshots

    @github-actions
    github-actions[bot] committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    f2edb8b View commit details
    Browse the repository at this point in the history

  11. Remove debug log

    @krassowski
    krassowski committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    565e82f View commit details
    Browse the repository at this point in the history

  12. Merge branch 'scroll-to-cell' of github.com:krassowski/jupyterlab int… 

    …o scroll-to-cell
    @krassowski
    krassowski committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    bd95dec View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Set right sidebar width

    @krassowski
    krassowski committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    332828e View commit details
    Browse the repository at this point in the history

  2. Update Playwright Snapshots

    @github-actions
    github-actions[bot] committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    f723782 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Revert bot update to debugger-variables

    @krassowski
    krassowski committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    15641a5 View commit details
    Browse the repository at this point in the history