Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localstack to 3.0.0 #1295

Merged
merged 4 commits into from
Nov 19, 2023
Merged

Update localstack to 3.0.0 #1295

merged 4 commits into from
Nov 19, 2023

Conversation

slang25
Copy link
Member

@slang25 slang25 commented Nov 19, 2023

This version includes support for the SQS JSON protocol

@slang25 slang25 requested a review from a team as a code owner November 19, 2023 12:30
Comment on lines +15 to +16
<PackageReference Include="AWSSDK.SimpleNotificationService" VersionOverride="3.7.300.5" />
<PackageReference Include="AWSSDK.SQS" VersionOverride="3.7.300.5" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL - does this work with dependabot?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I don't know, would be good to find out. There is also a feature that I can't find where you define versions in groups, and you can say in the package reference "I want the version from group A", can't remember how that works, so doing this for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can merge it and if it messes stuff up we can try something else.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6e91e0) 79.17% compared to head (3a526be) 78.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
- Coverage   79.17%   78.89%   -0.28%     
==========================================
  Files         138      138              
  Lines        3232     3232              
  Branches      451      451              
==========================================
- Hits         2559     2550       -9     
- Misses        442      451       +9     
  Partials      231      231              
Flag Coverage Δ
linux 78.89% <ø> (-0.28%) ⬇️
macos 49.28% <ø> (ø)
windows 49.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slang25 slang25 merged commit 0bfe698 into main Nov 19, 2023
13 of 14 checks passed
@slang25 slang25 deleted the update-localstack branch November 19, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants