Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localstack to 3.0.0 #1295

Merged
merged 4 commits into from
Nov 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ ForEach ($libraryProject in $libraryProjects) {
}

if (($null -ne $env:CI) -And ($EnableIntegrationTests -eq $true)) {
& docker pull --quiet localstack/localstack:2.2.0
& docker run -d --name localstack -p 4566:4566 localstack/localstack:2.2.0
& docker pull --quiet localstack/localstack:3.0.0
& docker run -d --name localstack -p 4566:4566 localstack/localstack:3.0.0
$env:AWS_SERVICE_URL = "http://localhost:4566"
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
<ProjectReference Include="..\JustSaying.TestingFramework\JustSaying.TestingFramework.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="AWSSDK.SimpleNotificationService" />
<PackageReference Include="AWSSDK.SQS" />
<PackageReference Include="AWSSDK.SimpleNotificationService" VersionOverride="3.7.300.5" />
<PackageReference Include="AWSSDK.SQS" VersionOverride="3.7.300.5" />
Comment on lines +15 to +16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL - does this work with dependabot?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I don't know, would be good to find out. There is also a feature that I can't find where you define versions in groups, and you can say in the package reference "I want the version from group A", can't remember how that works, so doing this for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can merge it and if it messes stuff up we can try something else.

<PackageReference Include="GitHubActionsTestLogger" />
<PackageReference Include="MartinCostello.Logging.XUnit" />
<PackageReference Include="MELT.Xunit" />
Expand Down
2 changes: 1 addition & 1 deletion tests/JustSaying.IntegrationTests/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ services:
localstack:
container_name: localstack
restart: unless-stopped
image: localstack/localstack:2.2.0
image: localstack/localstack:3.0.0
ports:
- 4566:4566
environment:
Expand Down
4 changes: 2 additions & 2 deletions tests/JustSaying.UnitTests/JustSaying.UnitTests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
<ProjectReference Include="..\JustSaying.TestingFramework\JustSaying.TestingFramework.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="AWSSDK.SimpleNotificationService" />
<PackageReference Include="AWSSDK.SQS" />
<PackageReference Include="AWSSDK.SimpleNotificationService" VersionOverride="3.7.300.5" />
<PackageReference Include="AWSSDK.SQS" VersionOverride="3.7.300.5" />
<PackageReference Include="GitHubActionsTestLogger" />
<PackageReference Include="MELT" />
<PackageReference Include="Microsoft.NET.Test.Sdk" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Amazon.Runtime;
using Amazon.Runtime.Endpoints;
using Amazon.SQS;
using Amazon.SQS.Model;

Expand Down Expand Up @@ -36,74 +37,79 @@ public Task<AddPermissionResponse> AddPermissionAsync(
string label,
List<string> awsAccountIds,
List<string> actions,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new AddPermissionResponse());
}

public Task<AddPermissionResponse> AddPermissionAsync(
AddPermissionRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new AddPermissionResponse());
}

public Task<CancelMessageMoveTaskResponse> CancelMessageMoveTaskAsync(CancelMessageMoveTaskRequest request, CancellationToken cancellationToken = default)
{
return Task.FromResult(new CancelMessageMoveTaskResponse());
}

public Task<ChangeMessageVisibilityResponse> ChangeMessageVisibilityAsync(
string queueUrl,
string receiptHandle,
int visibilityTimeout,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new ChangeMessageVisibilityResponse());
}

public Task<ChangeMessageVisibilityResponse> ChangeMessageVisibilityAsync(
ChangeMessageVisibilityRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new ChangeMessageVisibilityResponse());
}

public Task<ChangeMessageVisibilityBatchResponse> ChangeMessageVisibilityBatchAsync(
string queueUrl,
List<ChangeMessageVisibilityBatchRequestEntry> entries,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new ChangeMessageVisibilityBatchResponse());
}

public Task<ChangeMessageVisibilityBatchResponse> ChangeMessageVisibilityBatchAsync(
ChangeMessageVisibilityBatchRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new ChangeMessageVisibilityBatchResponse());
}

public Task<CreateQueueResponse> CreateQueueAsync(
string queueName,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new CreateQueueResponse());
}

public Task<CreateQueueResponse> CreateQueueAsync(
CreateQueueRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new CreateQueueResponse());
}

public Task<DeleteMessageResponse> DeleteMessageAsync(
string queueUrl,
string receiptHandle,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return DeleteMessageAsync(new DeleteMessageRequest(queueUrl, receiptHandle), cancellationToken);
}

public Task<DeleteMessageResponse> DeleteMessageAsync(
DeleteMessageRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
DeleteMessageRequests.Add(request);
return Task.FromResult(new DeleteMessageResponse());
Expand All @@ -113,57 +119,57 @@ public Task<DeleteMessageResponse> DeleteMessageAsync(
public Task<DeleteMessageBatchResponse> DeleteMessageBatchAsync(
string queueUrl,
List<DeleteMessageBatchRequestEntry> entries,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new DeleteMessageBatchResponse());
}

public Task<DeleteMessageBatchResponse> DeleteMessageBatchAsync(
DeleteMessageBatchRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new DeleteMessageBatchResponse());
}

public Task<DeleteQueueResponse> DeleteQueueAsync(
string queueUrl,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new DeleteQueueResponse());
}

public Task<DeleteQueueResponse> DeleteQueueAsync(
DeleteQueueRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new DeleteQueueResponse());
}

public Task<GetQueueAttributesResponse> GetQueueAttributesAsync(
string queueUrl,
List<string> attributeNames,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new GetQueueAttributesResponse());
}

public Task<GetQueueAttributesResponse> GetQueueAttributesAsync(
GetQueueAttributesRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new GetQueueAttributesResponse());
}

public Task<GetQueueUrlResponse> GetQueueUrlAsync(
string queueName,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return GetQueueUrlAsync(new GetQueueUrlRequest(queueName), cancellationToken);
}

public Task<GetQueueUrlResponse> GetQueueUrlAsync(
GetQueueUrlRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new GetQueueUrlResponse
{
Expand All @@ -173,49 +179,54 @@ public Task<GetQueueUrlResponse> GetQueueUrlAsync(

public Task<ListDeadLetterSourceQueuesResponse> ListDeadLetterSourceQueuesAsync(
ListDeadLetterSourceQueuesRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new ListDeadLetterSourceQueuesResponse());
}

public Task<ListMessageMoveTasksResponse> ListMessageMoveTasksAsync(ListMessageMoveTasksRequest request, CancellationToken cancellationToken = default)
{
return Task.FromResult(new ListMessageMoveTasksResponse());
}

public Task<ListQueuesResponse> ListQueuesAsync(
string queueNamePrefix,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new ListQueuesResponse());
}

public Task<ListQueuesResponse> ListQueuesAsync(
ListQueuesRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new ListQueuesResponse());
}

public Task<ListQueueTagsResponse> ListQueueTagsAsync(
ListQueueTagsRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new ListQueueTagsResponse());
}

public Task<PurgeQueueResponse> PurgeQueueAsync(
string queueUrl,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new PurgeQueueResponse());
}

public Task<PurgeQueueResponse> PurgeQueueAsync(
PurgeQueueRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new PurgeQueueResponse());
}

public Task<ReceiveMessageResponse> ReceiveMessageAsync(
string queueUrl,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return ReceiveMessageAsync(new ReceiveMessageRequest(queueUrl), cancellationToken);
}
Expand All @@ -224,7 +235,7 @@ public Task<ReceiveMessageResponse> ReceiveMessageAsync(
private IEnumerator<ReceiveMessageResponse> _getMessagesEnumerator;
public async Task<ReceiveMessageResponse> ReceiveMessageAsync(
ReceiveMessageRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
await Task.Delay(50, cancellationToken);

Expand All @@ -242,76 +253,86 @@ public async Task<ReceiveMessageResponse> ReceiveMessageAsync(
public Task<RemovePermissionResponse> RemovePermissionAsync(
string queueUrl,
string label,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new RemovePermissionResponse());
}

public Task<RemovePermissionResponse> RemovePermissionAsync(
RemovePermissionRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new RemovePermissionResponse());
}

public Task<SendMessageResponse> SendMessageAsync(
string queueUrl,
string messageBody,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new SendMessageResponse());
}

public Task<SendMessageResponse> SendMessageAsync(
SendMessageRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new SendMessageResponse());
}

public Task<SendMessageBatchResponse> SendMessageBatchAsync(
string queueUrl,
List<SendMessageBatchRequestEntry> entries,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new SendMessageBatchResponse());
}

public Task<SendMessageBatchResponse> SendMessageBatchAsync(
SendMessageBatchRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new SendMessageBatchResponse());
}

public Task<SetQueueAttributesResponse> SetQueueAttributesAsync(
string queueUrl,
Dictionary<string, string> attributes,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new SetQueueAttributesResponse());
}

public Task<SetQueueAttributesResponse> SetQueueAttributesAsync(
SetQueueAttributesRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new SetQueueAttributesResponse());
}

public Task<StartMessageMoveTaskResponse> StartMessageMoveTaskAsync(StartMessageMoveTaskRequest request, CancellationToken cancellationToken = default)
{
return Task.FromResult(new StartMessageMoveTaskResponse());
}

public Task<TagQueueResponse> TagQueueAsync(
TagQueueRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new TagQueueResponse());
}

public Task<UntagQueueResponse> UntagQueueAsync(
UntagQueueRequest request,
CancellationToken cancellationToken = new CancellationToken())
CancellationToken cancellationToken = default)
{
return Task.FromResult(new UntagQueueResponse());
}

public Endpoint DetermineServiceOperationEndpoint(AmazonWebServiceRequest request)
{
return new Endpoint("https://testqueues.com");
}

public ISQSPaginatorFactory Paginators { get; set; }
}
}