[Feat] 도안 등록 API 수정 프론트 반영 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoripong
requested changes
Oct 14, 2021
src/hooks/useFirebaseImageStorage.ts
Outdated
Comment on lines
38
to
39
| uploadResult: UploadStorage, | ||
| updatedResult: UploadStorage, |
There was a problem hiding this comment.
p3: 두개 너무 비슷해보이는데 이름에서 좀 더 확실히 구분이 됐으면 좋겠어요!
origin, updated 이런식으로..?!
There was a problem hiding this comment.
음 뜻은 업로드랑 업데이트된이라서 안 비슷하지 않나요 🤔
There was a problem hiding this comment.
upload랑 updated랑 의미는 전혀 다르고 여기서 헷갈리는게 아니라
updatedResult 가 나타내는 것은 updated 상태의 UploadResult 이고
uploadResult가 나타내는 것은 기존 상태의 UploadResult인데
updatedResult 에는 upload가 빠져있고, uploadResult에는 상태를 나타내는 단어가 빠져있어서 헷갈리는 것임니당
updatedUploadResult & originUploadResult 로 바꾸거나
updatedResult & originResult로 바꾸면 좋을 것 같습니당
There was a problem hiding this comment.
updatedUploadResult & originUploadResult 이걸루 바꿀게욤
jiyaaany
approved these changes
Oct 17, 2021
jiyaaany
approved these changes
Oct 19, 2021
zoripong
reviewed
Oct 20, 2021
zoripong
reviewed
Oct 20, 2021
|
아 근데 이 코멘트 (#119 (comment)) 는 아직 해결 안되긴 했네요 ㅋㅋㅋ |
YuuRiLee
force-pushed
the
create-design-post-edit
branch
from
8a54f3e
to
d7868b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #100
주요 변경 기록
Code review
Code review 에서 중점적으로 봐야하는 부분
Design review
Design review 에서 중점적으로 봐야하는 부분 / 스크린샷
기타 질문 및 특이 사항