-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 도안 등록 API 수정 프론트 반영 #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코멘트 확인해쥬세용!
src/hooks/useFirebaseImageStorage.ts
Outdated
uploadResult: UploadStorage, | ||
updatedResult: UploadStorage, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3: 두개 너무 비슷해보이는데 이름에서 좀 더 확실히 구분이 됐으면 좋겠어요!
origin, updated 이런식으로..?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 뜻은 업로드랑 업데이트된이라서 안 비슷하지 않나요 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upload랑 updated랑 의미는 전혀 다르고 여기서 헷갈리는게 아니라
updatedResult 가 나타내는 것은 updated 상태의 UploadResult 이고
uploadResult가 나타내는 것은 기존 상태의 UploadResult인데
updatedResult 에는 upload가 빠져있고, uploadResult에는 상태를 나타내는 단어가 빠져있어서 헷갈리는 것임니당
updatedUploadResult & originUploadResult 로 바꾸거나
updatedResult & originResult로 바꾸면 좋을 것 같습니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updatedUploadResult & originUploadResult 이걸루 바꿀게욤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8a54f3e 봐주세요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
행복한 PR이네요 당장 머지하시죠
아 근데 이 코멘트 (#119 (comment)) 는 아직 해결 안되긴 했네요 ㅋㅋㅋ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그암사합니드아 ❤️
8a54f3e
to
d7868b6
Compare
Resolve #100
주요 변경 기록
Code review
Code review 에서 중점적으로 봐야하는 부분
Design review
Design review 에서 중점적으로 봐야하는 부분 / 스크린샷
기타 질문 및 특이 사항