Some user-permission changes to btrfs-progs #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For non-root usage, receive can't write compressed data and will get EPERM, but falling back to writing uncompressed data may work and allows receive as a normal user, which is safer. Signed-off-by: Sweet Tea Dorminy <[email protected]>
The user ioctl works in all cases, so don't limit subvolume list to root by using the root-only ioctl. Subvolume list itself still uses the root-only tree search ioctl, but this is a step toward making subvolume list user-capable. Signed-off-by: Sweet Tea Dorminy <[email protected]>
|
For data writes it's totally fine to fallback to non-privileged writes. But wouldn't things like snapshotting and UUID tree updates still requires root privilege? |
|
Snapshotting shouldn't require root? But uuid search, good point, I was running on a kernel with uuid search allowed for non-root. |
|
There are the unprivileged subvolume ioctls, I'm not sure if there are also helpers for that but this should be possible to implement by manual iteration. |
kdave
force-pushed
the
devel
branch
4 times, most recently
from
247e2d2 to
208150e
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
0bbf8b9 to
bcb887a
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
87a1129 to
e4d372e
Compare
|
I'm taking another look, the idea of using unprivileged ioctls makes sense but we can go further and use the library functions (receive code is old so the interface was not there). I'd apply the patches but the change in lookup_ino_path() to |
kdave
force-pushed
the
devel
branch
2 times, most recently
from
ca84db7 to
8e8c554
Compare
kdave
force-pushed
the
devel
branch
3 times, most recently
from
c94327d to
2ce4219
Compare
kdave
force-pushed
the
devel
branch
4 times, most recently
from
082ce75 to
84c044d
Compare
kdave
force-pushed
the
devel
branch
6 times, most recently
from
ef43ce6 to
3eff852
Compare
kdave
force-pushed
the
devel
branch
4 times, most recently
from
dafafca to
5d47f58
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
bb6a159 to
0fb0189
Compare
kdave
force-pushed
the
devel
branch
3 times, most recently
from
0ad9c81 to
9c1d53d
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
5d51853 to
6ea7070
Compare
kdave
force-pushed
the
devel
branch
7 times, most recently
from
9551363 to
94c16d5
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
d82be5c to
25f665e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use btrfs receive as a regular user, and gets part of the way to using btrfs subvolume list as a regular user (the main change there is pretty big so it's going in a different pull request).