-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset for organizations #857
Conversation
@martin-kanis @vmuzikar @sguilhen Please, let me know if you want to add more operations/settings when provisioning organizations. I tried to start with the bare minimum to start working on the scalability of groups and identity providers. For the latter, it is already possible to see how much identity providers degrade performance when rendering login pages. |
Closes keycloak#856 Signed-off-by: Pedro Igor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedroigor Thanks, overall looks good to me. Please see my comments regarding usability.
Alternatively, you can create a single organization with a given name: | ||
|
||
---- | ||
realms/realm-0/dataset/orgs/create?name=myorg.com&domains=myorg.com,myorg.org,myorg.net&count=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameter count is required here but it doesn't make sense, as I want to create just one org and if I provide count=5 it is ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is a limitation. Otherwise, I'll need to create add another parameter just to make it optional.
linked to each organization created: | ||
|
||
---- | ||
.../realms/realm-0/dataset/orgs/create?count=1000&unmanaged-members-count=500&identity-providers-count=10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This crashes my Keycloak instance, consider lowering number of users or number of orgs in the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can create even more orgs than 1k. Do you have more details what it is failing for you?
...ava/org/keycloak/benchmark/dataset/organization/OrganizationIdentityProviderProvisioner.java
Show resolved
Hide resolved
Signed-off-by: Pedro Igor <[email protected]>
Signed-off-by: Pedro Igor <[email protected]>
Signed-off-by: Pedro Igor <[email protected]>
@pedroigor With the latest version and Keycloak 25, I'm getting
when running |
Closes #856