change(web): gestures polish pass 🐵 #9972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
keymanapp-test-bot
bot
removed
the
user-test-missing
mcdurdin
approved these changes
Nov 15, 2023
| @@ -435,6 +440,8 @@ export default class VisualKeyboard extends EventEmitter<EventMap> implements Ke | |||
| } | |||
| } | |||
|
|
|||
| // Fix: if flicks enabled, no roaming. | |||
There was a problem hiding this comment.
Not sure what this comment means?
There was a problem hiding this comment.
Suggested change
| // Fix: if flicks enabled, no roaming. |
It was likely a self-note that I forgot to remove once I accomplished the task. I tend to leave those at end-of-day so that I don't forget loose ends.
L457's if-block was the 'fix', so it's safe to remove.
Base automatically changed from
change/web/locked-flicks
to
feature-gestures
November 21, 2023 02:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes three things:
The next round of user-testing is specified on #9973. Since that'll cover the changes included here...
@keymanapp-test-bot skip