Customizable follow.limit #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NAR8789
force-pushed
the
feature/customizable-follow-limit
branch
from
f612814
to
e089f1f
Compare
NAR8789
commented
Oct 15, 2020
There was a problem hiding this comment.
🤔 questions / todo:
- magic number 10 is kind of littered around inside
view.js. Would it make sense to import that value fromstorage.js, or would importing fromstorage.jsbe smelly? - might be nice to just show expanded list for follows with only one entry (get rid of the toggle arrow, and show the full top post title, using the same amount of space)
- Looks like I'm pulling a string out of that number input. Should probably clean this up. (though, funnily, currenty does the right things--works as intended in the happy case, discards empty input (defaults to 10), keeps 0 (doesn't default to 10))
- seems not to be able to show more than 20 entries at the moment. some other limit I haven't found yet here...
NAR8789
force-pushed
the
feature/customizable-follow-limit
branch
from
b0ea069
to
bbba47c
Compare
|
@xiao-maven, @kickscondor, what's the current status of this feature? Would love to see this implemented, as many of my feeds update more than 10 times within a half of a day. |
|
I'm very sorry - I've been consumed with another project that is eating up all of my time through March. I was previously working on #30 - which adds pagination - a much better option than these limits - which requires no configuration. Once I'm able to get back to releasing that version, I'm hoping everyone interested in this pull request will be satisfied. If not, we can revisit this pull request at that time. Wish I had a better answer! I will get back to this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188: Customizable follow.limit. Allows customization of how many entries to show for a given follow, so I can e.g. show more entries for hackernews, because that thing is a firehose.
minvalidation doesn't currently work.What's the best way to test this thoroughly? My own use of Fraidycat so far is only as a browser extension, but I know it's available in a variety of forms.
Note: I'm the same person as @xiao-maven, requester of #188. I forgot to switch out of my work account earlier.