Require c++ stl for Kivy when sdl3 is used (Kivy 3.0.0)
#3181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misl6
changed the title
c++ stl for Kivy when sdl3 is used (Kivy 3.0.0)
AndreMiras
reviewed
Aug 3, 2025
Comment on lines
+39
to
+42
| if "sdl3" in self.ctx.recipe_build_order: | ||
| return True | ||
| else: | ||
| return False |
Member
There was a problem hiding this comment.
late post merge review, why not simply a one liner return "sdl3" in self.ctx.recipe_build_order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a dynamic property to the
KivyRecipeclass in thepythonforandroidproject to determine whether the shared STL library is required based on the presence ofsdl3in the build order.