Skip to content

Require c++ stl for Kivy when sdl3 is used (Kivy 3.0.0) #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
misl6 merged 1 commit into from
Jul 31, 2025
Merged

Require c++ stl for Kivy when sdl3 is used (Kivy 3.0.0) #3181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pythonforandroid/recipes/kivy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ class KivyRecipe(PyProjectRecipe):
# WARNING: Remove this patch when a new Kivy version is released.
patches = [("sdl-gl-swapwindow-nogil.patch", is_kivy_affected_by_deadlock_issue), "use_cython.patch"]

@property
def need_stl_shared(self):
if "sdl3" in self.ctx.recipe_build_order:
return True
else:
return False
Comment on lines +39 to +42
Copy link
Member

@AndreMiras AndreMiras Aug 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late post merge review, why not simply a one liner return "sdl3" in self.ctx.recipe_build_order


def get_recipe_env(self, arch, **kwargs):
env = super().get_recipe_env(arch, **kwargs)

Expand Down
Loading