dev: replace blocking_write with write
#552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftupas
changed the title
blocking_write with write
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
===========================================
+ Coverage 23.17% 72.76% +49.58%
===========================================
Files 9 45 +36
Lines 1247 4101 +2854
===========================================
+ Hits 289 2984 +2695
- Misses 958 1117 +159
☔ View full report in Codecov by Sentry. |
…ace-blockingwrite-with-write
ftupas
commented
Sep 13, 2023
…ace-blockingwrite-with-write
ftupas
force-pushed
the
dev/replace-blockingwrite-with-write
branch
from
bc7ffbd to
d4b6d36
Compare
greged93
reviewed
Sep 18, 2023
greged93
reviewed
Sep 18, 2023
9 tasks
anukkrit149
pushed a commit
to karnotxyz/kakarot-rpc
that referenced
this pull request
Aug 9, 2024
Time spent on this PR: 0.1 ## Pull request type Please check the type of change your PR introduces: - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? After removing the hardcoded Account for devnet, `get_account` was broken as testnet account uses `getPublicKey` case ## What is the new behavior? Fix `scripts.utils.get_account` for devnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.2
Resolves: #537
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
Replace
blocking_writeused in Katana sequencer withwriteDoes this introduce a breaking change?