Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Iterative Closest Point algorithm and 3d utils #182

Merged
merged 17 commits into from
Dec 16, 2024
Merged

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Dec 7, 2024

This pull request includes significant updates to the kornia-3d crate, adding new functionality and improving existing features. The most important changes include the addition of new dependencies, the introduction of new modules and functions, and updates to existing code to enhance functionality and performance.

New Dependencies and Modules

  • Added new dependencies such as approx, bincode, criterion, env_logger, faer, log, rand, serde, and thiserror to the Cargo.toml file.
  • Introduced new modules: linalg, ops, transforms, and vector in crates/kornia-3d/src/lib.rs.

New Functions and Benchmarks

  • Added functions for matrix and vector operations in crates/kornia-3d/src/linalg.rs, including transform_points3d, dot_product3, matmul33, transpose33, and mat_vec_mul33.
  • Introduced benchmarks for 3D point transformations and matrix multiplications in crates/kornia-3d/benches/bench_linalg.rs.

Point Cloud Data (PCD) Support

  • Added a new pcd module with a parser for PCD files in crates/kornia-3d/src/io/pcd/parser.rs.
  • Updated the io module to include the new pcd module in crates/kornia-3d/src/io/mod.rs.

Code Refactoring

  • Refactored the read_ply_binary function in crates/kornia-3d/src/io/ply/parser.rs to use arrays instead of Vec3 for points, colors, and normals.
  • Removed unused imports and cleaned up code in various files, such as crates/kornia-3d/src/io/colmap/text.rs.

@edgarriba edgarriba marked this pull request as ready for review December 16, 2024 10:54
@edgarriba edgarriba changed the title [wip] Implement Iterative Closest Point algorithm plus utils Implement Iterative Closest Point algorithm and 3d utils Dec 16, 2024
@edgarriba edgarriba linked an issue Dec 16, 2024 that may be closed by this pull request
@edgarriba edgarriba merged commit 15ecfb3 into main Dec 16, 2024
9 checks passed
@edgarriba edgarriba deleted the icp-pcl branch January 2, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ICP for 3d pointcloud registration
1 participant