Add group snapshot controller metrics #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Hi @yati1998. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
|
@yati1998 please write something in the PR descriptions release-note field. /ok-to-test |
k8s-ci-robot
added
ok-to-test
xing-yang
reviewed
Jun 15, 2024
pkg/metrics/metrics_test.go
Outdated
| expected := | ||
| `# HELP snapshot_controller_operation_total_seconds [ALPHA] Total number of seconds spent by the controller on an operation from end to end | ||
| # TYPE snapshot_controller_operation_total_seconds histogram | ||
| snapshot_controller_operation_total_seconds_bucket{driver_name="driver1",operation_name="op1",operation_status="Success",snapshot_type="",le="0.1"} 0 |
There was a problem hiding this comment.
For group snapshot, can you change the type from "snapshot_type" to "group_snapshot_type"?
There was a problem hiding this comment.
to create a new label, we have to replication the whole of operation metrics, which will unnecessarily replicate a lot, anyways, the value has to be same for it, what do you think?
There was a problem hiding this comment.
I added a comment to change to dynamic_group and pre-provisioned_group instead.
The individual volume snapshots are statically provisioned in this case, so I want to make the difference clear.
|
Can you also add test for statically provisioned group snapshots? |
xing-yang
reviewed
Jun 15, 2024
|
Can you also add test results for delete group snapshot? |
|
In the release note, please also add exactly what metric is added. |
unfortunately that's not working, cause deletion is getting suck as mentioned earlier. Will try to resolve that issue first. |
no new metric is added, we can use same metric to get the groupvolumesnapshot as well. |
this commit adds metrics for volumegroupsnapshot Signed-off-by: yati1998 <[email protected]>
Can you add the name of the metric in the release note? |
done |
xing-yang
reviewed
Jun 17, 2024
|
Please update the testing results. |
|
Please update test results with pre-provisioned group snapshots and add a "TODO" in the PR description for delete group snapshot. |
# TYPE process_start_time_seconds gauge
process_start_time_seconds 1.71845164359e+09
# HELP snapshot_controller_operation_total_seconds [ALPHA] Total number of seconds spent by the controller on an operation
# TYPE snapshot_controller_operation_total_seconds histogram
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="0.1"} 0
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="0.25"} 0
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="0.5"} 0
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="1"} 0
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="2.5"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="5"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="10"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="15"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="30"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="60"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="120"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="300"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="600"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned",le="+Inf"} 2
snapshot_controller_operation_total_seconds_sum{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned"} 4.770233558
snapshot_controller_operation_total_seconds_count{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshot",operation_status="success",snapshot_type="pre-provisioned"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="0.1"} 0
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="0.25"} 0
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="0.5"} 0
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="1"} 0
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="2.5"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="5"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="10"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="15"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="30"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="60"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="120"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="300"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="600"} 2
snapshot_controller_operation_total_seconds_bucket{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned",le="+Inf"} 2
snapshot_controller_operation_total_seconds_sum{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned"} 4.780226055
snapshot_controller_operation_total_seconds_count{driver_name="hostpath.csi.k8s.io",operation_name="CreateGroupSnapshotAndReady",operation_status="success",snapshot_type="pre-provisioned"} 2
# HELP snapshot_controller_operations_in_flight [ALPHA] Total number of operations in flight
# TYPE snapshot_controller_operations_in_flight gauge
snapshot_controller_operations_in_flight 2 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xing-yang, yati1998 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR introduces new operation like CreateGroupsnapshot, DeleteGroupsnapshots, etc to the existing metrics
Testing
TODO
Add output for deleteGroupSnapshot operation
Which issue(s) this PR fixes:
Fixes # 1081
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?: