Skip to content

Conversation

@vitorfloriano
Copy link
Contributor

This PR fixes the issue in which the copy button would not be displayed in code blocks generated by literate-go.

Related to #4862 and #5175.

Before:

image

After:

image

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vitorfloriano. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 9, 2025
@camilamacedo86
Copy link
Member

After your review I was looking and deliberate those were skiped
So, I am wondering if we should really display them.
Maybe we need to check if they are working well in all places
WDYT?

@vitorfloriano
Copy link
Contributor Author

After your review I was looking and deliberate those were skiped So, I am wondering if we should really display them. Maybe we need to check if they are working well in all places WDYT?

@camilamacedo86 I think it was removed as a matter of personal taste. But IMO we should keep them. Pretty much every website that displays code blocks have a copy button in them, so it's basically a standard of UX.

@camilamacedo86 camilamacedo86 changed the title 🐛 fix(docs): display copy button on codeblocks 📖 : fix(docs): display copy button on codeblocks Nov 9, 2025
@camilamacedo86
Copy link
Member

@vitorfloriano

OK. So, lets get merged and if someone complain then we revisit it.
I think you made a fair point.

/approved
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2025
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, vitorfloriano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2025
@camilamacedo86 camilamacedo86 merged commit caa85e6 into kubernetes-sigs:master Nov 9, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants