-
Notifications
You must be signed in to change notification settings - Fork 1.6k
📖 : fix(docs): display copy button on codeblocks #5184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 : fix(docs): display copy button on codeblocks #5184
Conversation
|
Hi @vitorfloriano. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
After your review I was looking and deliberate those were skiped |
@camilamacedo86 I think it was removed as a matter of personal taste. But IMO we should keep them. Pretty much every website that displays code blocks have a copy button in them, so it's basically a standard of UX. |
|
OK. So, lets get merged and if someone complain then we revisit it. /approved |
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approved
/ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, vitorfloriano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes the issue in which the copy button would not be displayed in code blocks generated by literate-go.
Related to #4862 and #5175.
Before:
After: