Update hasObjectChangedInGivenFields to ignore predefined fields #1355
Conversation
Reference: https://issues.redhat.com/browse/MTV-1546 - Check if the inventory data has changed for re-loading the data to UI and re-rendering only for specified fields by ignoring a pre-defined list of fields. - Remove unused hasObjectChangedInGivenFields duplicate method implementation. Up till now, all fields have been compared to check if something was changed for reloading. But since there are few fields that are changed occasionally in inventory, while not being displayed in UI, we can ignore them while checking for new data, for less requent unnecessary re-rendering. Signed-off-by: Sharon Gratch <[email protected]>
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
==========================================
- Coverage 36.81% 36.16% -0.65%
==========================================
Files 158 158
Lines 2548 2577 +29
Branches 599 601 +2
==========================================
- Hits 938 932 -6
- Misses 1428 1630 +202
+ Partials 182 15 -167 ☔ View full report in Codecov by Sentry. |
packages/forklift-console-plugin/src/modules/Providers/hooks/utils/constants.ts
Show resolved
Hide resolved
|
Hi @ernesgonzalez33 |
|
@sgratch This one should fix the EC issues: kubev2v/forklift#1110 |
Reference: https://issues.redhat.com/browse/MTV-1546
hasObjectChangedInGivenFieldsduplicate method implementation.Up till now, all fields have been compared to check if something was changed for reloading. But since there are few fields that are changed occasionally in inventory, while not being displayed in UI, we can ignore them while checking for new data, for less requent unnecessary re-rendering.