Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hasObjectChangedInGivenFields to ignore predefined fields #1355

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Update hasObjectChangedInGivenFields to ignore predefined fields #1355

merged 1 commit into from
Oct 15, 2024
+40 −66

Commits on Oct 15, 2024

  1. Update hasObjectChangedInGivenFields to ignore predefined fields 

    Reference: https://issues.redhat.com/browse/MTV-1546

- Check if the inventory data has changed for re-loading the data to UI
and re-rendering only for specified fields by ignoring a pre-defined list of fields.
- Remove unused hasObjectChangedInGivenFields duplicate method
  implementation.

Up till now, all fields have been compared to check if something was
changed for reloading. But since there are few fields that are changed occasionally in inventory,
while not being displayed in UI, we can ignore them while checking for new data, for less requent unnecessary re-rendering.

Signed-off-by: Sharon Gratch <[email protected]>
    @sgratch
    sgratch committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e24a243 View commit details
    Browse the repository at this point in the history