Improve "convert to PIL" example #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default color type of a `skia.Image` is platform dependent. On some systems (e.g., GitHub CI, and most Linux systems) the default color type is BGR (for endianness purposes). See https://github.com/google/skia/blob/6ffe89f9b4cc8c1dae9c4a916f16f9c463e3fa6d/include/core/SkColorType.h#L58-L62 Thus, in general, not only one has to convert the `alphaType` to create a PIL image, but also the `colorType`.
|
I am wondering if it is possible to detect what skia's image color type is (such as a class static method), and also adds a few more tests to the pytests. |
|
Oh, we do expose the skia-python/src/skia/ImageInfo.cpp Line 62 in e0b030c |
HinTak
approved these changes
Jul 27, 2024
|
The merge commit failed CI because of the Centos EOL July 2024 issue - that's fixed by the m127/m128 pulls. we can ignore the failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default color type of a
skia.Imageis platform dependent. On some systems (e.g., GitHub CI, and most Linux systems) the default color type is BGR (for endianness purposes).See https://github.com/google/skia/blob/6ffe89f9b4cc8c1dae9c4a916f16f9c463e3fa6d/include/core/SkColorType.h#L58-L62
Thus, in general, not only one has to convert the
alphaTypeto create a PIL image, but also thecolorType.