Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "convert to PIL" example #250

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Improve "convert to PIL" example #250

merged 1 commit into from
Jul 27, 2024

Commits on Jun 1, 2024

  1. Improve "convert to PIL" example 

    The default color type of a `skia.Image` is platform dependent. On some systems (e.g., GitHub CI, and most Linux systems) the default color type is BGR (for endianness purposes).

See https://github.com/google/skia/blob/6ffe89f9b4cc8c1dae9c4a916f16f9c463e3fa6d/include/core/SkColorType.h#L58-L62

Thus, in general, not only one has to convert the `alphaType` to create a PIL image, but also the `colorType`.
    @lucach
    lucach committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    f7e9403 View commit details
    Browse the repository at this point in the history