cmake: replace include(FindFFTW.cmake) with find_dependency(FFTW) in installed config - #16
Merged
Merged
Conversation
…ves2AMRConfig.cmake.in
Copilot
AI
changed the title
[WIP] Fix CMake developer warning for FFTW dependency
cmake: replace include(FindFFTW.cmake) with find_dependency(FFTW) in installed config
Jul 30, 2026
…e mismatch warning
jrood-nrel
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream consumers of the installed package get a CMake developer warning because
Waves2AMRConfig.cmakedirectlyinclude()sFindFFTW.cmake, causingfind_package_handle_standard_args(FFTW …)to fire whileCMAKE_FIND_PACKAGE_NAMEis stillWaves2AMR— a name mismatch CMake flags as a bug.Changes
cmake/Waves2AMRConfig.cmake.in: replace theinclude(…/FindFFTW.cmake)workaround withfind_dependency(FFTW). TheCMAKE_MODULE_PATHprepend (already present on line 3) makesFindFFTW.cmakediscoverable, sofind_dependencysets the correctCMAKE_FIND_PACKAGE_NAME=FFTWcontext before invoking the module.find_dependency(FFTW)"doesn't work" — it does, onceCMAKE_MODULE_PATHis set first.