Skip to content

cmake: replace include(FindFFTW.cmake) with find_dependency(FFTW) in installed config #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrood-nrel merged 3 commits into from
Jul 30, 2026
Merged

cmake: replace include(FindFFTW.cmake) with find_dependency(FFTW) in installed config #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13db18b
Initial plan
Copilot Jul 30, 2026
111eb02
Fix: replace include(FindFFTW.cmake) with find_dependency(FFTW) in Wa…
Copilot Jul 30, 2026
91507ae
Fix: use CMAKE_FIND_PACKAGE_NAME override to silence FFTW package-nam…
Copilot Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions cmake/Waves2AMRConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,17 @@ include(CMakeFindDependencyMacro)

find_dependency(AMReX)

#This works upstream
# find_dependency(FFTW) is not used here because environments that set
# CMAKE_FIND_PACKAGE_PREFER_CONFIG=ON (e.g. Spack) skip module mode entirely,
# so FindFFTW.cmake is never invoked. Instead we include the module directly
# with CMAKE_FIND_PACKAGE_NAME set to the correct value so that
# find_package_handle_standard_args does not emit a package-name mismatch
# warning.
set(_waves2amr_saved_find_package_name "${CMAKE_FIND_PACKAGE_NAME}")
set(CMAKE_FIND_PACKAGE_NAME FFTW)
include("${PACKAGE_PREFIX_DIR}/@CMAKE_INSTALL_DATADIR@/cmake/Modules/FindFFTW.cmake")
#This does not and it feels like a bug because it doesn't invoke FindFFTW.cmake at all
#find_dependency(FFTW)
set(CMAKE_FIND_PACKAGE_NAME "${_waves2amr_saved_find_package_name}")
unset(_waves2amr_saved_find_package_name)

include("${CMAKE_CURRENT_LIST_DIR}/@PROJECT_NAME@Targets.cmake")

Expand Down
Loading