Flather BC - #2024
Draft
mbkuhn wants to merge 64 commits into
Draft
Conversation
- use old state unless during initialization
mbkuhn
commented
Aug 28, 2026
Comment on lines
+446
to
+451
| const amrex::Real c = std::sqrt(grav_z * interior_h); | ||
|
|
||
| const auto Flather_vel = | ||
| boundary_val + (ori.isLow() ? -1.0_rt : 1.0_rt) * c / | ||
| boundary_h * (interior_h - boundary_h); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I am unsure about the fact I use interior_h to calculate c and then use boundary_h as the multiplier in Flather_vel. The formula in the literature is unclear about where to get h from (interior or boundary) but in some cases, these values are at least assumed to be the same, such that sqrt(g H)/H is written as sqrt(g / H).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| , m_v_mac(m_sim.repo().get_field("v_mac")) | ||
| , m_vof(m_sim.repo().get_field("vof")) | ||
| { | ||
| // amrex::ParmParse pp(identifier()); |
… this avoids dividing by 0
…ty if there are no pure liquid cells
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Issue Number: