Flather BC - #2024

Draft

mbkuhn wants to merge 64 commits into

kynema:mainfrom

mbkuhn:flather_bc

Commits on Aug 21, 2026

skeleton for Flather
mbkuhn
committed
60ad11e
starting to do averages
mbkuhn
committed
8d4f33f
now for any lateral boundary
mbkuhn
committed
01873d8
vof is assumed
mbkuhn
committed
e1e9dd7
include terrain feature
mbkuhn
committed
04c9bb6
include averages within boundary
mbkuhn
committed
9482b90
compute water height as well
mbkuhn
committed
abb35b7

Commits on Aug 22, 2026

basic Flather velocity calculation
mbkuhn
committed
f846972

Commits on Aug 24, 2026

Commits on Aug 25, 2026

forgot to resize some of the arrays
mbkuhn
committed
edcdb78
remove unnecessary variable
mbkuhn
committed
28a6ba5
start to make changes to do subsequent field fillpatch boundaries
mbkuhn
committed
2e7a201
fix check inside set_default_fillpatch_bc
mbkuhn
committed
e8583fe
don't mess up sibling fields. Not sure exactly what to do instead
mbkuhn
committed
75b1a6d
get the indices right for cell centers in set_velocity
mbkuhn
committed
b7eb413
remove offsets for domain lo, that's always 0
mbkuhn
committed
2eeb191
restrict to normal components
mbkuhn
committed
857cda3

Commits on Aug 26, 2026

found the bug!!!!
mbkuhn
committed
c15a9f3
use idx_max better
mbkuhn
committed
a201171
avoid using Flather modification if it is going to pull in gas
mbkuhn
committed
312b4ee
remove unnecessary check for velocity field
mbkuhn
committed
c340b53
- always reference field, not mfab
mbkuhn
committed
4b3e266
separate internal and boundary calcs so that the correct data is used
mbkuhn
committed
cba4321
give non-const access to multi-level vector
mbkuhn
committed
eadcb57

Commits on Aug 27, 2026

make field for averaging depend on incoming state
mbkuhn
committed
de6060a
state considerations for vof
mbkuhn
committed
a6cebe9
use mac velocities for averaging calculations when appropriate
mbkuhn
committed
c6de51f
remove unused field, add some const
mbkuhn
committed
0f266fb
make sure to not mess up the states with mac fields
mbkuhn
committed
6016005
average over the correct indices for face velocities
mbkuhn
committed
8866f12
include shifts to cell-centered data when operating on face fields (mac velocity)
mbkuhn
committed
ff491d4
use prescribed velocity as starting point for inflow
mbkuhn
committed
b5a521a
forgot conditional for mac fields
mbkuhn
committed
d5ab8b5

Commits on Aug 28, 2026

update final conditional
mbkuhn
committed
7ef2018
formatting
mbkuhn
committed
77ddffc
Merge branch 'main' into flather_bc
mbkuhn
authored
57d3d48

Commits on Sep 1, 2026

address unused variables
mbkuhn
committed
34ececc
addressed missed _rt
mbkuhn
committed
8f06842
remove redundant cast
mbkuhn
committed
8f098d6
address some more unused variables
mbkuhn
committed
7407202
prescribe Flather vel uniformly if averaged_vel is under a threshold; this avoids dividing by 0
mbkuhn
committed
f4d1cee
fix dangling reference
mbkuhn
committed
7b461d0
get unit tests to pass
mbkuhn
committed
33db42d
scaling should only apply to liquid
mbkuhn
committed
5b41688

Commits on Sep 2, 2026

avoid modifying mixed outflow cells - modify unit test later
mbkuhn
committed
859def0
add another outflow case
mbkuhn
committed
d78c389
maybe this will help with convergence
mbkuhn
committed
1ad9fae

Commits on Sep 3, 2026

update unit test
mbkuhn
committed
c61c64b
prevent inflow at outflow
mbkuhn
committed
1c573cb
expand outputs to include boundary cells
mbkuhn
committed
5b6ab03
correct phase switch for multiphase cells
mbkuhn
committed
3607683
avoid dividing by 0, override multiphase velocity with Flather velocity if there are no pure liquid cells
mbkuhn
committed
20b4821
more conditionals
mbkuhn
committed
ffcd7a2
address case where boundary_h = 0
mbkuhn
committed
dadd7ea
put a check against large scales
mbkuhn
committed
1fac42a

Commits on Sep 4, 2026

basic outflow if boundary_h is too small
mbkuhn
committed
33d93ab
another edge case?
mbkuhn
committed
8fbdb04
correct conditional
mbkuhn
committed
7cbfc12
try a limit on the scale
mbkuhn
committed
ad0f3fc
try overriding interior instead
mbkuhn
committed
0fed0f0