Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: generalize device adoption #1937

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feature: generalize device adoption #1937

wants to merge 9 commits into from

Conversation

inureyes
Copy link
Member

This PR generalizes device support to enable future ASIC support without code modification.

This PR is a part of #1203

@inureyes inureyes self-assigned this Sep 21, 2023
@github-actions github-actions bot added the size:XL 500~ LoC label Sep 21, 2023
@inureyes inureyes added area:ux UI / UX issue. urgency:5 It is imperative that action be taken right away. type:refactor Refactoring current implementation. platform:general area:impl Implementation issue. effort:epic Need to split into multiple sub-issues (epic). impact:invisible This change is invisible to users (internal changes). field:UI / UX and removed size:XL 500~ LoC labels Sep 21, 2023
@aws-amplify-ap-northeast-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1937.d3g9cs6u59b8lw.amplifyapp.com

@github-actions github-actions bot added size:XL 500~ LoC and removed field:UI / UX labels Sep 22, 2023
@inureyes inureyes mentioned this pull request Apr 5, 2024
Merged
6 tasks
@yomybaby yomybaby mentioned this pull request Sep 5, 2024
Merged
@inureyes inureyes marked this pull request as ready for review September 19, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@inureyes inureyes

Labels
area:impl Implementation issue. area:ux UI / UX issue. effort:epic Need to split into multiple sub-issues (epic). impact:invisible This change is invisible to users (internal changes). platform:general size:XL 500~ LoC type:refactor Refactoring current implementation. urgency:5 It is imperative that action be taken right away.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inureyes @lizable