fix: improve worker launch logic - #2547
Open
linhr wants to merge 2 commits into
Open
Conversation
Gold Data ReportNotes
Commit Information
Summary
DetailsGold Data Metrics
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Concurrent session creation, retry-exhaustion state, and invalid configuration handling have unresolved correctness issues.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Improves distributed worker startup, retry handling, resource accounting, and session activation consistency.
Changes:
- Tracks pending workers and enforces worker-count limits.
- Adds configurable finite worker-launch retry schedules.
- Makes driver activation acknowledged and idempotent.
File summaries
| File | Description |
|---|---|
crates/sail-session/src/session_manager/session.rs |
Adds the creating session state. |
crates/sail-session/src/session_manager/actor/message.rs |
Adds asynchronous creation completion messaging. |
crates/sail-session/src/session_manager/actor/handler.rs |
Waits for driver activation before completing creation. |
crates/sail-session/src/session_manager/actor/core.rs |
Routes creation completion messages. |
crates/sail-execution/src/driver/worker_pool/state.rs |
Stores worker launch metadata. |
crates/sail-execution/src/driver/worker_pool/mod.rs |
Exposes launch types internally. |
crates/sail-execution/src/driver/worker_pool/core.rs |
Reports launch failures and preserves retry state. |
crates/sail-execution/src/driver/task_assigner/state.rs |
Adds pending worker resources. |
crates/sail-execution/src/driver/task_assigner/options.rs |
Adds a test constructor. |
crates/sail-execution/src/driver/task_assigner/mod.rs |
Removes separate requested-worker accounting. |
crates/sail-execution/src/driver/task_assigner/core.rs |
Calculates demand using pending capacity and limits. |
crates/sail-execution/src/driver/registry.rs |
Waits for activation acknowledgement. |
crates/sail-execution/src/driver/actor/options.rs |
Adds worker retry configuration. |
crates/sail-execution/src/driver/actor/mod.rs |
Tracks activation and exhausted retries. |
crates/sail-execution/src/driver/actor/message.rs |
Adds activation results and retry messages. |
crates/sail-execution/src/driver/actor/handler.rs |
Consolidates launches and implements retries. |
crates/sail-execution/src/driver/actor/core.rs |
Routes new driver messages. |
crates/sail-common/src/utils/retry.rs |
Adds reusable finite retry schedules and tests. |
crates/sail-common/src/config/application.yaml |
Defines worker-launch retry settings. |
crates/sail-common/src/config/application.rs |
Adds retry strategy to cluster configuration. |
Review details
- Files reviewed: 20/20 changed files
- Comments generated: 4
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Spark 3.5.9 Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff(empty) Failed Tests |
Spark 4.2.0 Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff--- before.txt 2026-09-04 05:26:02.840022812 +0000
+++ after.txt 2026-09-04 05:26:03.180021585 +0000
@@ -1893,0 +1894 @@
+pyspark/sql/tests/connect/test_parity_functions.py::FunctionsParityTests::test_make_timestampFailed Tests(truncated) |
Ibis Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff--- before.txt 2026-09-04 05:25:10.938811057 +0000
+++ after.txt 2026-09-04 05:25:11.149813234 +0000
@@ -1491,0 +1492 @@
+ibis/backends/tests/test_udf.py::test_vectorized_udf[pyspark-add_one_pandas]Failed Tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track requested worker withIntroduceWorkerResource::Pendingin the task assigner to have a better estimate on the worker demand.WorkerScalerto manage worker demand and worker launch retry.worker_task_slotsconfiguration and clampworker_initial_counttoworker_max_count.