Skip to content

fix: improve worker launch logic - #2547

Merged
linhr merged 3 commits into
mainfrom
worker-count-fix
Sep 5, 2026
Merged

fix: improve worker launch logic#2547
linhr merged 3 commits into
mainfrom
worker-count-fix

Update

def9723
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 5, 2026 in 0s

78.16% (-1.07%) compared to 06da176

View this Pull Request on Codecov

78.16% (-1.07%) compared to 06da176

Details

Codecov Report

❌ Patch coverage is 74.61431% with 181 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../sail-session/src/session_manager/actor/handler.rs 56.38% 82 Missing ⚠️
crates/sail-execution/src/driver/actor/handler.rs 48.35% 47 Missing ⚠️
...es/sail-execution/src/driver/worker_scaler/core.rs 87.70% 23 Missing ⚠️
...ates/sail-execution/src/driver/worker_pool/core.rs 50.00% 8 Missing ⚠️
crates/sail-execution/src/driver/actor/message.rs 25.00% 6 Missing ⚠️
...es/sail-execution/src/driver/task_assigner/core.rs 92.64% 5 Missing ⚠️
crates/sail-execution/src/driver/actor/core.rs 50.00% 4 Missing ⚠️
crates/sail-execution/src/driver/actor/options.rs 70.00% 3 Missing ⚠️
...tes/sail-session/src/session_factory/job_runner.rs 60.00% 2 Missing ⚠️
crates/sail-session/src/session_manager/session.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main    #2547      +/-   ##
==========================================
- Coverage   79.22%   78.16%   -1.07%     
==========================================
  Files         988      991       +3     
  Lines      205066   205585     +519     
==========================================
- Hits       162462   160690    -1772     
- Misses      42604    44895    +2291     
Files with missing lines Coverage Δ
crates/sail-common/src/config/application.rs 86.80% <ø> (+4.56%) ⬆️
crates/sail-common/src/utils/retry.rs 100.00% <100.00%> (+54.09%) ⬆️
crates/sail-execution/src/driver/registry.rs 86.66% <100.00%> (+0.45%) ⬆️
...tes/sail-execution/src/driver/task_assigner/mod.rs 100.00% <ø> (ø)
...sail-execution/src/driver/task_assigner/options.rs 100.00% <100.00%> (ø)
...tes/sail-execution/src/driver/worker_scaler/mod.rs 100.00% <100.00%> (ø)
...sail-execution/src/driver/worker_scaler/options.rs 100.00% <100.00%> (ø)
crates/sail-execution/src/id.rs 82.75% <ø> (ø)
...tes/sail-session/src/session_manager/actor/core.rs 92.77% <100.00%> (+0.66%) ⬆️
.../sail-session/src/session_manager/actor/message.rs 78.57% <100.00%> (+13.18%) ⬆️
... and 10 more

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.