Add a Contributing guide #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of this PR is to move the changes in laminas/laminas-form#65 to a more globally accessible location, one that can be referenced in all of the sub-repositories of the Laminas and Mezzio organisations. Signed-off-by: Matthew Setter <[email protected]>
settermjd
force-pushed
the
add-contributing-guide
branch
from
d3b245a
to
5c22f25
Compare
geerteltink
reviewed
May 3, 2020
arueckauer
suggested changes
May 8, 2020
This change: - Updates the reference to the Yaml snippet so that it's more generic, and applicable to any project, and doesn't use a fixed line range reference. - Removes the ampersand from the serve command reference, so that no errors are thrown for Windows users. - Updates the setup instructions to reference the PyMdown extension Signed-off-by: Matthew Setter <[email protected]>
settermjd
force-pushed
the
add-contributing-guide
branch
from
187fd32
to
02c22b2
Compare
froschdesign
requested changes
May 26, 2020
There was a problem hiding this comment.
Beside my small notes, a question is still open: should we add the way via update script?
python /path/to/documentation-theme/update_mkdocs_yml.py 'https://docs.laminas.dev/laminas-form' docs/bookResponded to two points of feedback.
I don't quite follow what you're asking. Chat with you later today, on Slack. |
froschdesign
requested changes
Jan 11, 2021
| To do so, you first need to do three things; these are: | ||
|
|
||
| 1. Have MkDocs installed. | ||
| 2. Have the Laminas documentation theme available to the laminas-form directory. |
There was a problem hiding this comment.
Suggested change
| 2. Have the Laminas documentation theme available to the laminas-form directory. | |
| 2. Have the Laminas documentation theme available to the current repository directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The intent of this PR is to move the changes in laminas/laminas-form#65 to a more globally accessible location, one that can be referenced in all of the sub-repositories of the Laminas and Mezzio organisations.