Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a docs contributing guide to the README #65

Conversation

settermjd
Copy link
Contributor

@settermjd settermjd commented Apr 30, 2020

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

My intention in doing this is to help others get started easier than I did the first time (this time) by including a clear set of instructions that step them through how to build the documentation locally, so that they know that they changes which they contribute will render properly, as they expect them to.

A big thanks to @froschdesign for helping me get started.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@froschdesign
Copy link
Member

froschdesign commented Apr 30, 2020

@weierophinney
This is a very good extension and we need the explanation. (The path with Docker should be added too.)
But I would move this to a separate repository like documentation. There we can add some more content like a documentation writer's guide.
All contents can be displayed under docs.laminas.dev and linked in the readme files.

@weierophinney
Copy link
Member

@weierophinney
This is a very good extension and we need the explanation. (The path with Docker should be added too.)
But I would move this to a separate repository like documentation. There we can add some more content like a documentation writer's guide.
All contents can be displayed under docs.laminas.dev and linked in the readme files.

I would argue for:

  • Put this information in the documentation repository.
  • Add a section in the laminas/.github CONTRIBUTING.md file titled "Contributing Documentation" that summarizes the "we use Markdown and MkDocs" information, and then links to the larger write-up in the documentation repository. (And do this in each of the .github repos of each organization)

@froschdesign
Copy link
Member

Very good, I hadn't thought of that at all. 👍

@settermjd
Copy link
Contributor Author

Thanks for the feedback, everyone. I'll get it done.

@settermjd
Copy link
Contributor Author

settermjd commented May 1, 2020

@weierophinney
This is a very good extension and we need the explanation. (The path with Docker should be added too.)
But I would move this to a separate repository like documentation. There we can add some more content like a documentation writer's guide.
All contents can be displayed under docs.laminas.dev and linked in the readme files.

Did you mean the "documentation-theme" repository? Otherwise, I'm not sure which repository you mean.

@weierophinney
Copy link
Member

Did you mean the "documentation-theme" repository? Otherwise, I'm not sure which repository you mean.

We had a documentation repo in the ZF org for tracking projects. I never migrated it here, as it didn't have code, mostly projects...

@froschdesign I can transfer that repo to the Laminas org, if you'd like; that would give us the projects. I hadn't thought of that, as everything else we were migrating, and then archiving. Let me know if that's what you'd like, or if you'd like me to create a documentation repo.

@settermjd
Copy link
Contributor Author

Did you mean the "documentation-theme" repository? Otherwise, I'm not sure which repository you mean.

We had a documentation repo in the ZF org for tracking projects. I never migrated it here, as it didn't have code, mostly projects...

@froschdesign I can transfer that repo to the Laminas org, if you'd like; that would give us the projects. I hadn't thought of that, as everything else we were migrating, and then archiving. Let me know if that's what you'd like, or if you'd like me to create a documentation repo.

I'm all for it being migrated, @weierophinney

@froschdesign
Copy link
Member

@weierophinney

I can transfer that repo to the Laminas org, if you'd like…

That would be great. Thanks in advance!

@weierophinney
Copy link
Member

That would be great. Thanks in advance!

DONE! https://github.com/laminas/documentation

I was wrong - no projects, just issues. But they're all there now.

@settermjd
Copy link
Contributor Author

That would be great. Thanks in advance!

DONE! https://github.com/laminas/documentation

I was wrong - no projects, just issues. But they're all there now.

Thanks for doing that, @weierophinney.

settermjd added a commit to settermjd/documentation that referenced this pull request May 2, 2020
The intent of this PR is to move the changes in
laminas/laminas-form#65 to a more globally
accessible location, one that can be referenced in all of the
sub-repositories of the Laminas and Mezzio organisations.

Signed-off-by: Matthew Setter <[email protected]>
@settermjd
Copy link
Contributor Author

settermjd commented May 2, 2020

I moved the contributing documentation to the documentation repository in laminas/documentation#15. I've added the relevant information to CONTRIBUTING.md in Mezzio's .github in mezzio/.github#6 and Laminas' .github in laminas/.github#8.

settermjd added a commit to settermjd/.github that referenced this pull request May 2, 2020
This is part of updating the documentation of all repositories to show
how to contribute to the documentation, as recommended in
laminas/laminas-form#65 (comment).

Signed-off-by: Matthew Setter <[email protected]>
settermjd added a commit to settermjd/.github-mezzio that referenced this pull request May 2, 2020
This is part of updating the documentation of all repositories to show
how to contribute to the documentation, as recommended in
laminas/laminas-form#65 (comment).

Signed-off-by: Matthew Setter <[email protected]>
@settermjd settermjd requested a review from samsonasik May 2, 2020 14:54
My intention in doing this is to help others get started easier than I
did the first time (this time) by including a clear set of instructions
that step them through how to build the documentation locally, so that
they know that they changes which they contribute will render properly,
as they expect them to. A big thanks to @froschdesign for helping me get
started.

Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
@settermjd settermjd force-pushed the update-readme-with-docs-contributing-details branch from f5c34b3 to c679801 Compare May 4, 2020 04:00
@froschdesign
Copy link
Member

@settermjd

I moved the contributing documentation to the documentation repository in laminas/documentation#15.

This is the right place for it. The link is already included in the global contributing guidelines for this organisation.

The link to the guidelines is added under each comment and issue text field and in the community section of the repository.

To avoid duplication, we should use one place for the text and close this pull request. Improvements for text should be added to the documentation repository.

We already use the content so nothing is lost.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants