Reducing the complexity of view helpers

[mimmi20]

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	no
RFC	no
QA	yes

Description

This PR wants to reduce the complexity of the FormCollection and the FormRow View Helpers. Also an psalm issue is fixed.

[gsteel]

This will fix psalm issues in #260

[Xerkus]

Is there a reason int was allowed in the first place?

[mimmi20]

see #256 (comment)

[okoram]

I think removing 'int' causes a BC Break. For example, if we want to generate pagination and we use only numbers:

$value = 10;

/** @var \Laminas\Form\Element\Select $field */
$field = $this->get('items_per_page');

$values = [];
for ($i = 1; $i < 4; $i++) {
    $val = $i * $value;

    $values[$val] = $val;
}

$field->setValueOptions($values);

Error message:

Laminas\Form\View\Helper\AbstractHelper::translateLabel(): Argument # 1 ($label) must be of type string, int given, called in .../laminas/laminas-form/src/View/Helper/FormSelect.php on line 201

laminas-form/src/View/Helper/FormSelect.php

Line 201 in ffdf00a

$label = $this->translateLabel($label);

The solution is the need to always remember to cast all values to string:

$values[$val] = (string) $val;

Shouldn't this change be accompanied by a change: #256?

[gsteel]

I'm with you here. A (string) cast should be used for all calls, or translateLabel should be altered to accept scalar and perform the cast there.

Conversely, all labels should be string values regardless, so I do think it's up to the user to convert labels to strings first, but that doesn't stop this from being a BC break based on existing behaviour.

[gsteel]

See #261

[Xerkus]

@mimmi20 github having incident currently. You might want to wait until problem is resolved.

[Slamdunk]

Reviewed with split-diff and hidden-whitespaces: LGTM

[Xerkus]

Just to note.

This and following parts lost conditional for $this->renderErrors.
Behavior remains correct because $elementErrors is an empty string with render errors checked at line 155 that is not part of the diff.

[Xerkus]

@mimmi20 thank you