Fix BC break preventing the use of scalar element labels during render #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Steel <[email protected]>
String is the correct argument type, but it is not possible to implement in the 3.x series Signed-off-by: George Steel <[email protected]>
|
Can non-string even be translated? I feel non-string label should be returned verbatim. |
Xerkus
approved these changes
Jan 11, 2024
gsteel
changed the title
Xerkus
changed the title
Xerkus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#259 introduces a BC break requiring element labels (and select value options) to be
string. This patch adds a failing test that passes on previous minors.