Improve type inference for FormElementManager::get() #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slamdunk
approved these changes
Jan 9, 2024
Xerkus
requested changes
Jan 9, 2024
Signed-off-by: George Steel <[email protected]>
… exception. Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
form-element-manager-template
branch
from
b27ab4c to
cb68f54
Compare
Signed-off-by: George Steel <[email protected]>
…ed the same as a string literal Signed-off-by: George Steel <[email protected]>
Xerkus
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you provide
FormElementManager::get()with a FQCN, it infersElementInterfaceinstead of the given FQCN. This patch fixes that…There are some un-related psalm issues from recent patches. Let me know if you want these baselined here