-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L10n support with english default #15
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
<?php | ||
|
||
return [ | ||
/* | ||
|-------------------------------------------------------------------------- | ||
| Authentication Language Lines | ||
|-------------------------------------------------------------------------- | ||
| | ||
| The following language lines are used during authentication for various | ||
| messages that we need to display to the user. You are free to modify | ||
| these language lines according to your application's requirements. | ||
| | ||
*/ | ||
'failed' => 'These credentials do not match our records.', | ||
'throttle' => 'Too many login attempts. Please try again in :seconds seconds.', | ||
'passwords' => [ | ||
'confirm' => [ | ||
'title' => 'Confirm your password', | ||
'subtitle' => 'Please continue your password before continuing', | ||
'forgot_password_link' => 'Forgot your password?', | ||
'confirm_password_action' => 'Confirm password' | ||
], | ||
'email' => [ | ||
'title' => 'Reset password', | ||
'send_password_reset_link_action' => 'Send password reset link' | ||
], | ||
'reset' => [ | ||
'title' => 'Reset password', | ||
'confirm_password_action' => 'Confirm Password', | ||
'reset_password_action' => 'Reset Password' | ||
], | ||
], | ||
'login' => [ | ||
'title' => 'Sign in to your account', | ||
'subtitle' => [ | ||
'pre' => 'Or', | ||
'link' => 'create a new account', | ||
], | ||
'remember_label' => 'Remember', | ||
'forgot_password_link' => 'Forgot your password?', | ||
'sign_in_action' => 'Sign in', | ||
], | ||
'register' => [ | ||
'title' => 'Create a new account', | ||
'subtitle' => [ | ||
'pre' => 'Or', | ||
'link' => 'sign in to your account', | ||
], | ||
'confirm_password_label' => 'Confirm Password', | ||
'register_action' => 'Register' | ||
], | ||
'verify' => [ | ||
'title' => 'Verify your email address', | ||
'subtitle' => [ | ||
'pre' => 'Or', | ||
'link' => 'sign out', | ||
], | ||
'resent_verification_link' => 'A fresh verification link has been sent to your email address.', | ||
'check_email_for_link' => 'Before proceeding, please check your email for a verification link.', | ||
'email_not_received' => [ | ||
'pre' => 'If you did not receive the email, ', | ||
'link' => 'click here to request another.', | ||
] | ||
], | ||
'links' => [ | ||
'register' => 'Register', | ||
'login' => 'Login', | ||
'logout' => 'Log out' | ||
], | ||
'labels' => [ | ||
'email' => 'Email address', | ||
'password' => 'Password', | ||
'username' => 'Name', | ||
], | ||
]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get why this is done, but it doesn't necessarily work to have "pre" and "link" text separately like this. It works for what the current English text is, but that won't be the case for every language.
What I prefer doing for things like this is to use parameters where I can, which lets the translator move it about and put text before or after the link if they need to:
That does make it a bit more awkward to handle how to actually put the anchor HTML in there though.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't feel right to me but I get your point.
Do you have any experience in doing this? I'm quite clueless on this right now.