Skip to content

Conversation

remicollet
Copy link
Contributor

Because of this, build is strangely failing (8.4 only)

make[1]: *** No rule to make target 'routes/yaf_route_map.c', needed by 'routes/yaf_route_map.lo'. Stop.

In Makefile.objects (notice the space in the path)

Makefile: routes/yaf_route_map.lo: /builddir/build/BUILD/php-pecl-yaf-3.3.6-build/php-pecl-yaf-3.3.6/yaf-3.3.6/ routes/yaf_route_map.c

@remicollet
Copy link
Contributor Author

Without Second commit:

TEST 38/133 [tests/038.phpt]
========DIFF========
001- Parse error: syntax error, unexpected %s}%c in %sfoo.phtml on line %d
001+ Parse error: syntax error, unexpected token "{" in /work/GIT/pecl-and-ext/yaf/tests/application/tpls/foo.phtml on line 2
========DONE========
FAIL Check for Yaf_View_Simple error message outputing [tests/038.phpt] 
TEST 39/133 [tests/039.phpt]
========DIFF========
001- syntax error, unexpected %s}%c
001+ syntax error, unexpected token "{"
========DONE========
FAIL Check for Yaf_View_Simple recursive render error message outputing [tests/039.phpt] 

@remicollet
Copy link
Contributor Author

Using PHP 8.4.0RC1 and this patch

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :     0
Exts tested     :    17
---------------------------------------------------------------------

Number of tests :   133               130
Tests skipped   :     3 (  2.3%) --------
Tests warned    :     0 (  0.0%) (  0.0%)
Tests failed    :     0 (  0.0%) (  0.0%)
Tests passed    :   130 ( 97.7%) (100.0%)
---------------------------------------------------------------------
Time taken      : 2.615 seconds
=====================================================================

- use zend_ce_exception instead of zend_exception_get_default
- use ZSTR_ALLOCA_* instead of STR_ALLOCA_*
- relax test expectation in error message
@remicollet
Copy link
Contributor Author

New commit for PHP 8.5

With 8.5.0alpha2

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :     0
Exts tested     :    19
---------------------------------------------------------------------

Number of tests :   133               130
Tests skipped   :     3 (  2.3%) --------
Tests warned    :     0 (  0.0%) (  0.0%)
Tests failed    :     0 (  0.0%) (  0.0%)
Tests passed    :   130 ( 97.7%) (100.0%)
---------------------------------------------------------------------
Time taken      : 3.089 seconds
=====================================================================

@remicollet remicollet changed the title remove trailing space remove trailing space, fix for PHP 8.4 and 8.5 Jul 18, 2025
@remicollet remicollet changed the title remove trailing space, fix for PHP 8.4 and 8.5 Fixes for PHP 8.4 and 8.5 Jul 18, 2025
@laruence
Copy link
Owner

seems the actions failed, I may merge in this week, thanks

@laruence laruence merged commit 4fab1d1 into laruence:master Jul 29, 2025
1 of 12 checks passed
@remicollet remicollet deleted the issue-php84 branch July 29, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants