refactor(fork-choice): make internal attestation-extraction helper private - #1136
Merged
tcoratger merged 1 commit intoJun 17, 2026
Conversation
…ivate The attestation-extraction helper sits in the same private LMD-GHOST pipeline as its siblings, which are underscore-prefixed, yet it was public despite having no callers outside its own module. Rename it to match its siblings. Pure rename, behavior identical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename the attestation-extraction helper in the lstar fork-choice mixin from a public method to a private (underscore-prefixed) one, and update its three internal call sites.
Why
The helper lives in the same private LMD-GHOST weight-accumulation pipeline as its siblings (the ancestor-weight accumulator and the GHOST-head computer), both of which are underscore-prefixed. This one was public despite being called only from within its own module — a naming inconsistency that implied a public API surface that does not exist.
A repo-wide grep over
src/,tests/, andpackages/confirms there are no external or test callers; all four references are within the fork-choice module itself.This is a pure rename. Behavior is identical, and
just checkpasses (lint, format, type check, spell, mdformat, lock).🤖 Generated with Claude Code