Skip to content

refactor(fork-choice): make internal attestation-extraction helper private #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcoratger merged 1 commit into from
Jun 17, 2026
Merged

refactor(fork-choice): make internal attestation-extraction helper private #1136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/lean_spec/spec/forks/lstar/fork_choice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ def on_block(

return store

def extract_attestations_from_aggregated_payloads(
def _extract_attestations_from_aggregated_payloads(
self,
aggregated_payloads: dict[AttestationData, set[SingleMessageAggregate]],
latest_finalized_slot: Slot,
Expand Down Expand Up @@ -722,7 +722,7 @@ def compute_block_weights(self, store: LstarStore) -> dict[Bytes32, int]:
Each block root mapped to its accumulated vote weight.
"""
# Reduce the counted pool to each validator's latest still-relevant vote.
latest_votes = self.extract_attestations_from_aggregated_payloads(
latest_votes = self._extract_attestations_from_aggregated_payloads(
store.latest_known_aggregated_payloads,
store.latest_finalized.slot,
)
Expand Down Expand Up @@ -809,7 +809,7 @@ def update_head(self, store: LstarStore) -> LstarStore:
The store with its head set to the chosen block.
"""
# Reduce the counted pool to each validator's latest still-relevant vote.
latest_votes = self.extract_attestations_from_aggregated_payloads(
latest_votes = self._extract_attestations_from_aggregated_payloads(
store.latest_known_aggregated_payloads,
store.latest_finalized.slot,
)
Expand Down Expand Up @@ -896,7 +896,7 @@ def update_safe_target(self, store: LstarStore) -> LstarStore:
min_target_score = math.ceil(num_validators * 2 / 3)

# Reduce the pending pool to each validator's latest still-relevant vote.
latest_votes = self.extract_attestations_from_aggregated_payloads(
latest_votes = self._extract_attestations_from_aggregated_payloads(
store.latest_new_aggregated_payloads,
store.latest_finalized.slot,
)
Expand Down
Loading