Chore/4391/devtooling #2
Conversation
pete-watters
force-pushed
the
chore/4391/devtooling
branch
2 times, most recently
from
2291d8a
to
f4682b8
Compare
pete-watters
force-pushed
the
chore/4391/devtooling
branch
from
f4682b8
to
d79aa7d
Compare
pete-watters
force-pushed
the
chore/4391/devtooling
branch
from
2e8c233
to
b54e8cd
Compare
| "@changesets/cli": "^2.26.2", | ||
| "@commitlint/cli": "^18.0.0", | ||
| "@commitlint/config-conventional": "^18.0.0", | ||
| "@leather-wallet/eslint-config": "workspace:^", |
There was a problem hiding this comment.
workspace:^ means they are installed here from the local workspace
There was a problem hiding this comment.
do we want this or workspace:*? Thought I saw that in the nx vids
There was a problem hiding this comment.
You are right, there he declares them as *. I can change it but I'm not 100% what's best to use.
This is the default used by pnpm.
On the pnpm docs they give this example:
On that Nx tutorial they use * but I amn't sure if it gives us benefit
Any ideas what is best for us? 🤔
There was a problem hiding this comment.
I changed it to * but that caused the CI jobs to fail with:
Let's keep it as is for now to keep momentum and we can open an issue to change it if it will bring a big benefit?
| }, | ||
| extends: [ | ||
| 'plugin:@typescript-eslint/recommended', | ||
| // 'plugin:react/recommended', |
There was a problem hiding this comment.
I just commented these out for now. I need to figure out how to extend this file passing in these values in the extension.
I didn't want to add react plugins here as some packages won't need them. Maybe I should?
| "noFallthroughCasesInSwitch": true, | ||
| "moduleResolution": "node", | ||
| "resolveJsonModule": true, | ||
| // "baseUrl": "src", |
There was a problem hiding this comment.
I just commented this for now. I'll remove when integrating to the extension
markmhendrickson
requested review from
fbwoolf
and removed request for
kyranjamie
markmhendrickson
requested review from
fbwoolf,
alter-eggo and
edgarkhanzadian
There was a problem hiding this comment.
Looks great @pete-watters, awesome start.
Do we need to repeat the LICENSE files?
| engine-strict = true | ||
| auto-install-peers = true |
There was a problem hiding this comment.
needed if we're using pnpm?
There was a problem hiding this comment.
Not 100% needed - works without so I can remove if you think we don't need to add it?
I just added it based on a monorepo template I was following and it seemed useful
| "@changesets/cli": "^2.26.2", | ||
| "@commitlint/cli": "^18.0.0", | ||
| "@commitlint/config-conventional": "^18.0.0", | ||
| "@leather-wallet/eslint-config": "workspace:^", |
There was a problem hiding this comment.
do we want this or workspace:*? Thought I saw that in the nx vids
We don't need to repeat them but I thought if we are publishing packages independently it's nice to have them bundled with all they need, including license. I can easily remove them though to trim things down |
# This is the 1st commit message: feat: add web storybook and some design components # This is the commit message #2: refactor: move index file to src # This is the commit message #3: refactor: expose components through @leather-wallet/design-system/{native|web} # This is the commit message #4: refactor: run syncpack format
This PR adds some changes to the mono-repo:
eslint-configpackagetsconfig-configpackagehuskyandcommitlintto enforce standards locallyI did not publish the new packages to
npmyet. The next step I see is to either:Nxand setup automatic releasespanda+ design tokens in then the other libsI found this good example setup I have mostly been taking inspiration from / copying:
He is also using some other things we could consider: