LPD-68453 Clear filters button doesn't fully clear all filters #5127

thektan · 2025-10-14T03:01:59Z

Bug Ticket: https://liferay.atlassian.net/browse/LPD-68453

This fixes the clear filter buttons (in the active filters bar/empty state) to clear the pre-loaded filter. This was previously mutating the object so the component wasn't re-rendering so now it returns a new object. This was also how the logic worked before.

Previously the dispatch looked like:

		viewsDispatch({
			type: VIEWS_ACTION_TYPES.UPDATE_FILTERS,
			value: filters.map((filter) => ({
				...filter,
				active: false,
				odataFilterString: undefined,
				selectedData: undefined,
			})),
		});

When a filter is active on initial load due to `preloadedData`, clicking the "Clear Filters" button fails to clear the filter from the UI if the user has not interacted with it first. The `deactivateFilter` utility function was directly mutating the filter object, which prevented React from detecting a state change and re-rendering the UI. The function is now updated to return a new, immutable object, ensuring React sees the change and updates the UI correctly.

liferay-continuous-integration · 2025-10-14T03:02:04Z

CI is automatically triggering the following test suites:

ci:test:sf

liferay-continuous-integration · 2025-10-14T03:02:06Z

Test suite sf has been triggered on http://test-1-31

liferay-continuous-integration · 2025-10-14T03:06:30Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Ran com.liferay.source.formatter at released version 1.0.1544.
*The latest version has not been released.

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 25cca0d75ec64ed6265f8101d9c9e9296e5bd620

Sender Branch:

Branch Name: LPD-68453_FixFilterClear
Branch GIT ID: cf5eba1e8af86a565652c1ffbda0ec8d0c4dd4a8

1 out of 1 jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2025-10-14T03:06:49Z

Jenkins Build:test-portal-source-format#7855

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#5127

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - thektan > liferay-frontend - PR#5127 - 2025-10-13[20:02:37]

Testray Build ID:338879973

Testray Importer:test-portal-source-format#7855

thektan · 2025-10-14T03:08:48Z

ci:test:frontend-data-set

liferay-continuous-integration · 2025-10-14T03:08:55Z

Test suite frontend-data-set has been triggered on http://test-1-25

liferay-continuous-integration · 2025-10-14T04:14:18Z

❌ ci:test:frontend-data-set - 3 out of 6 jobs passed in 56 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 25cca0d75ec64ed6265f8101d9c9e9296e5bd620

Upstream Comparison:

Branch GIT ID: f54453ace69577a7fb5ba5535e9e2ec0f618c787
Jenkins Build URL: EE Development Acceptance (master) - 171 - 2025-10-07[08:39:50]

ci:test:frontend-data-set - 3 out of 6 jobs PASSED

3 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
js-unit
- js-unit/0/0
modules-unit
- modules-unit/0/0
playwright-js-tomcat101-postgresql163

3 Successful Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-10-14T04:16:51Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#8592

Jenkins Report:jenkins-report.html

Jenkins Suite:frontend-data-set

Pull Request:liferay-frontend#5127

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:frontend-data-set - thektan > liferay-frontend - PR#5127 - 2025-10-13[20:17:06]

Testray Build ID:338921226

Testray Importer:test-portal-acceptance-pullrequest(master)#8592

dsanz · 2025-10-15T07:43:45Z

Great catch @thektan , my bad.

I'd like to review the activateFilter utility as well, because that one does mutate the filter. There is a case (getInitialViewState) where original code mutated the filter and I'd say that's why I wrongly implemented utilities in that way. Here returning a new object is not strictly needed but won't hurt.

The other usage is a bit more convoluted, I believe this one would benefit from returning a new object. could you please take a deeper look? Thx

markocikos

@thektan LGTM! ✨

thektan · 2025-10-16T01:18:10Z

@dsanz I'm going to keep activateFilter the same. I was attempting to make it avoid any mutations, but it resulted in more issues with the filters not even applying anymore. I noticed places require possibly bigger changes like in Filter.tsx where it depends on the mutation happening.

Also it looks like activateFilter was implemented the same way it was before. With the mutations.

For example:

In the filter resume dropdown, if you unchecked all the selections and then clicked "Delete Filter", the filter resume label would still show for example: "Color:". This is because `setFilter` needs to be able to also set `active: false` but `activateFilter` was always setting `active: true`

thektan · 2025-10-16T20:14:23Z

Added a change to fix the filter resume not fully clearing.

Kapture.2025-10-16.at.12.08.00.mp4

Also might be something broken with the forward/back history navigation, but I can't reliably reproduce it. It seems sometimes the forward history gets wiped out when you hit back navigation to the initial state (plus it gets suck there where continually hitting back navigation does nothing). 🙃

Mainly looking at this test specifically:

thektan · 2025-10-16T20:14:32Z

ci:test:frontend-data-set

liferay-continuous-integration · 2025-10-16T20:14:39Z

Test suite frontend-data-set has been triggered on http://test-1-34

liferay-continuous-integration · 2025-10-16T21:21:37Z

❌ ci:test:frontend-data-set - 3 out of 6 jobs passed in 1 hour 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2018e7596b60007f382316cc000ce88d1994c6fa

Upstream Comparison:

Branch GIT ID: 6bfad7c5eeca7396b9756980c32197057cc003f2
Jenkins Build URL: EE Development Acceptance (master) - 179 - 2025-10-10[20:39:27]

ci:test:frontend-data-set - 3 out of 6 jobs PASSED

3 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
js-unit
- js-unit/0/0
modules-unit
- modules-unit/0/0
playwright-js-tomcat101-postgresql163

3 Successful Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-10-16T21:24:35Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#8485

Jenkins Report:jenkins-report.html

Jenkins Suite:frontend-data-set

Pull Request:liferay-frontend#5127

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:frontend-data-set - thektan > liferay-frontend - PR#5127 - 2025-10-16[13:14:47]

Testray Build ID:341358492

Testray Importer:test-portal-acceptance-pullrequest(master)#8485

liferay-continuous-integration · 2025-10-17T00:00:21Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#8493

Jenkins Report:jenkins-report.html

Jenkins Suite:frontend-data-set

Pull Request:liferay-frontend#5127

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:frontend-data-set - thektan > liferay-frontend - PR#5127 - 2025-10-16[15:58:08]

Testray Build ID:341435753

Testray Importer:test-portal-acceptance-pullrequest(master)#8493

thektan · 2025-10-17T19:17:51Z

ci:test:sf

thektan · 2025-10-17T19:17:55Z

ci:test:relevant

liferay-continuous-integration · 2025-10-17T19:17:57Z

Test suite sf has been triggered on http://test-1-37

liferay-continuous-integration · 2025-10-17T19:18:00Z

Test suite relevant has been triggered on http://test-1-37

liferay-continuous-integration · 2025-10-17T19:22:13Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Ran com.liferay.source.formatter at released version 1.0.1545.

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 78a6ca4c2979693076ee386c488ca64ed9999dc8

Sender Branch:

Branch Name: LPD-68453_FixFilterClear
Branch GIT ID: 13d91610f462a19ae56d27744f90cc291a047900

1 out of 1 jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2025-10-17T19:22:30Z

Jenkins Build:test-portal-source-format#13983

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#5127

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - thektan > liferay-frontend - PR#5127 - 2025-10-17[12:18:03]

Testray Build ID:342071436

Testray Importer:test-portal-source-format#13983

liferay-continuous-integration · 2025-10-17T20:21:39Z

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 14 out of 16 jobs passed in 1 hour 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 78a6ca4c2979693076ee386c488ca64ed9999dc8

Upstream Comparison:

Branch GIT ID: 2018e7596b60007f382316cc000ce88d1994c6fa
Jenkins Build URL: EE Development Acceptance (master) - 195 - 2025-10-16[12:39:48]

ci:test:stable - 11 out of 11 jobs PASSED

11 Successful Jobs:

ci:test:relevant - 14 out of 16 jobs PASSED

2 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
functional-upgrade-tomcat101-postgresql163_stable
js-unit
modules-integration-postgresql163_stable
- modules-integration-postgresql163_stable/0/0
modules-semantic-versioning
- modules-semantic-versioning/0/0
playwright-js-tomcat101-mysql84
playwright-js-tomcat101-postgresql163_stable
- playwright-js-tomcat101-postgresql163_stable/0/0
unit_stable
- unit_stable/0/0

14 Successful Jobs:

For more details click here.

Failures unique to this pull:

playwright-js-tomcat101-mysql84/1/1 - Playwright Report
1. frontend-data-set-admin-web/main/tests/data-set-fragment/selectionFilters.spec.ts
  Selection filter of type "API REST Application" with a composed field name is displayed in the fragment
2. frontend-data-set-admin-web/main/tests/data-set-fragment/itemActions.spec.ts
  Item Actions in Data Set fragment › Async and Headless Item Actions (multiple actions) are shown in fragment
  Item Actions in Data Set fragment › Async and Headless Item Actions (multiple actions) performs UPDATE operations on items

For upstream results, click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-10-17T20:23:27Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#24391

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#5127

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - thektan > liferay-frontend - PR#5127 - 2025-10-17[12:18:08]

Testray Build ID:342081986

Testray Importer:test-portal-acceptance-pullrequest(master)#24391

thektan · 2025-10-18T00:09:48Z

@dsanz @markocikos As a heads up I changed the solution to only return a new object since the config in URL navigation would break (when clearing the filters, navigating back and forward if the filter wasn't mutated 🙃.

Looks like this allows everything to work as expected now:

export function deactivateFilter(filter: any) {
	filter.active = false;
	filter.odataFilterString = undefined;
	filter.selectedData = undefined;

	return {
		...filter,
	};
}

kresimir-coko

LGTM 👍

thektan · 2025-10-20T18:42:20Z

ci:forward:force

liferay-continuous-integration · 2025-10-20T18:42:25Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf
ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

ci:test:relevant
ci:test:sf
AND If the following test suites pass:
ci:test:stable

liferay-continuous-integration · 2025-10-20T18:42:26Z

Skipping previously completed test suites:

ci:test:relevant
ci:test:sf
AND Skipping previously passed test suites:
ci:test:stable

liferay-continuous-integration · 2025-10-20T18:42:27Z

Test suite default has been triggered on http://test-1-26

liferay-continuous-integration · 2025-10-20T18:43:03Z

All required test suite(s) completed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2025-10-20T18:43:29Z

Pull request has been successfully forwarded to brianchandotcom#166833
Console

thektan requested a review from liferay-frontend as a code owner October 14, 2025 03:02

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Oct 14, 2025

liferay-continuous-integration added ci:test:frontend-data-set - pending ci:test:frontend-data-set - failure and removed ci:test:frontend-data-set - pending labels Oct 14, 2025

markocikos approved these changes Oct 15, 2025

View reviewed changes

thektan added 2 commits October 16, 2025 12:13

LPD-68453 playwright: Remove unnecessary double check

a0ce1c0

liferay-continuous-integration added ci:test:frontend-data-set - pending ci:test:frontend-data-set - failure and removed ci:test:frontend-data-set - failure ci:test:frontend-data-set - pending labels Oct 16, 2025

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Oct 17, 2025

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Oct 17, 2025

kresimir-coko approved these changes Oct 20, 2025

View reviewed changes

liferay-continuous-integration added the ci:forward:force label Oct 20, 2025

liferay-continuous-integration mentioned this pull request Oct 20, 2025

LPD-68453 Clear filters button doesn't fully clear all filters brianchandotcom/liferay-portal#166833

Closed

liferay-continuous-integration closed this Oct 20, 2025

LPD-68453 Clear filters button doesn't fully clear all filters #5127

LPD-68453 Clear filters button doesn't fully clear all filters #5127

Uh oh!

Conversation

thektan commented Oct 14, 2025

Uh oh!

liferay-continuous-integration commented Oct 14, 2025

Uh oh!

liferay-continuous-integration commented Oct 14, 2025

Uh oh!

liferay-continuous-integration commented Oct 14, 2025

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

Uh oh!

liferay-continuous-integration commented Oct 14, 2025

Uh oh!

thektan commented Oct 14, 2025

Uh oh!

liferay-continuous-integration commented Oct 14, 2025

Uh oh!

liferay-continuous-integration commented Oct 14, 2025

❌ ci:test:frontend-data-set - 3 out of 6 jobs passed in 56 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

Test bundle downloads:

Uh oh!

liferay-continuous-integration commented Oct 14, 2025

Uh oh!

dsanz commented Oct 15, 2025

Uh oh!

markocikos left a comment

Choose a reason for hiding this comment

Uh oh!

thektan commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thektan commented Oct 16, 2025

Uh oh!

thektan commented Oct 16, 2025

Uh oh!

liferay-continuous-integration commented Oct 16, 2025

Uh oh!

liferay-continuous-integration commented Oct 16, 2025

❌ ci:test:frontend-data-set - 3 out of 6 jobs passed in 1 hour 6 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

Test bundle downloads:

Uh oh!

liferay-continuous-integration commented Oct 16, 2025

Uh oh!

liferay-continuous-integration commented Oct 17, 2025

Uh oh!

thektan commented Oct 17, 2025

Uh oh!

thektan commented Oct 17, 2025

Uh oh!

liferay-continuous-integration commented Oct 17, 2025

Uh oh!

liferay-continuous-integration commented Oct 17, 2025

Uh oh!

liferay-continuous-integration commented Oct 17, 2025

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

Uh oh!

liferay-continuous-integration commented Oct 17, 2025

Uh oh!

liferay-continuous-integration commented Oct 17, 2025

✔️ ci:test:stable - 11 out of 11 jobs passed

thektan commented Oct 16, 2025 •

edited

Loading