Skip to content

LPD-68453 Clear filters button doesn't fully clear all filters #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

LPD-68453 Clear filters button doesn't fully clear all filters #5127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf5eba1
LPD-68453 Ensure preloaded filters are cleared correctly
thektan Oct 14, 2025
e77006c
LPD-68453 Fix filter resume not fully removing when unselecting items
thektan Oct 16, 2025
a0ce1c0
LPD-68453 playwright: Remove unnecessary double check
thektan Oct 16, 2025
13d9161
LPD-68453 Fix browser navigation when clearing filters
thektan Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...-set-web/src/main/resources/META-INF/resources/management_bar/controls/filters/Filter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {loadModule} from 'frontend-js-web';
import React, {ReactElement, useContext, useEffect, useState} from 'react';

import FrontendDataSetContext from '../../../FrontendDataSetContext';
import {activateFilter} from '../../../utils/filters/activateFilter';
import ViewsContext from '../../../views/ViewsContext';

// @ts-ignore
Expand Down Expand Up @@ -97,10 +96,14 @@ const Filter = ({
...filters.find(
(filter: FilterConfiguration) => filter.id === filterId
),
selectedData,
...otherProps,
};

activateFilter({filter: newFilter, selectedData});
newFilter.odataFilterString =
filterImplementation.getOdataString(newFilter);
newFilter.selectedItemsLabel =
filterImplementation.getSelectedItemsLabel(newFilter);

setSearching(true);

Expand Down
4 changes: 3 additions & 1 deletion ...tend-data-set-web/src/main/resources/META-INF/resources/utils/filters/deactivateFilter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,7 @@ export function deactivateFilter(filter: any) {
filter.odataFilterString = undefined;
filter.selectedData = undefined;

return filter;
return {
...filter,
};
}
2 changes: 0 additions & 2 deletions ...les/test/playwright/tests/frontend-data-set-web/main/tests/advanced/config_in_url.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,6 @@ for (const spaConfiguration of spaConfigurations) {
});

await test.step('Check back navigation', async () => {
await checkFilter(true, 'color', 'Color: Green, Red');

await page.goBack();
await checkFilter(true, 'color', 'Color: Yellow, Green');
await page.goBack();
Expand Down