Bump vendored Eigen to 5.0.1 #78
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the vendored Eigen library from 3.4.0 to 5.0.1, with compatibility patches applied during build to Ceres Solver 2.2.0.
Changes
5.0.1(commit bc3b398)ceres-solver-src/patches/0001-support-eigen-5.patchwith compatibility changesCMakeLists.txt: Support Eigen version range3.3...5with fallbackcovariance_impl.ccandinvert_psd_matrix.h: Handle Eigen 5.x SVD constructor API changeceres-solver-src/build.rsto apply patches automatically during buildceres-solver-src/Cargo.tomlto reflecteigen5.0.1Technical Details
Eigen 5.x changed the SVD constructor API from runtime to compile-time options:
Compatibility is maintained via
EIGEN_VERSION_AT_LEAST(5, 0, 0)preprocessor guards.Implementation Approach
The patches are applied during the build process rather than modifying the submodule directly. This ensures that:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.