BOLT 2: option_shutdown_anysegwit (Feature 26/27)
#672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfromknecht
approved these changes
Oct 18, 2019
|
ACK e8f8a79 |
|
Can land once rebased! |
|
Assigned features 22/23. |
rustyrussell
force-pushed
the
opt_shutdown_moreversions
branch
from
e8f8a79 to
2df5c06
Compare
|
Rebased on top of master, assigned feature bits as per http://www.erisian.com.au/meetbot/lightning-dev/2020/lightning-dev.2020-08-17-20.08.html |
rustyrussell
added
the
Awaiting Interop
18 tasks
|
As discussed on IRC, needs feature bit bump to not conflict with #824 |
cdecker
force-pushed
the
opt_shutdown_moreversions
branch
from
2df5c06 to
75c02f9
Compare
|
Clean rebase on top of |
cdecker
force-pushed
the
opt_shutdown_moreversions
branch
from
765e26d to
4acbb39
Compare
|
Featurebits bumped from 22/23 to 24/25 as per specification meeting 2020/12/20 |
This was referenced Jan 5, 2021
21 tasks
ariard
reviewed
Jan 28, 2021
| 4. `OP_0` `32` 32-bytes (version 0 pay to witness script hash) | ||
| 4. `OP_0` `32` 32-bytes (version 0 pay to witness script hash), OR | ||
| 5. if (and only if) `opt_shutdown_anysegwit` is negotiated: | ||
| * `OP_1` through `OP_16` inclusive, followed by a single push of 2 to 40 bytes |
There was a problem hiding this comment.
Beware that your is_witness_program() is bip 141 compliant, otherwise if the witness program size is unbounded the non-funder counterparty might inflate its scriptpubkey to burn in fees the funder balance.
23 tasks
TheBlueMatt
reviewed
Feb 11, 2021
There was a problem hiding this comment.
I'm not sure if it makes sense to clarify, but to check with others, the way I read this, if I disconnect from a peer, then reconnect with new features bits set, you can opt into onlysegwit on an old channel as long as you didn't set an upfront shutdown script. I think thats correct and a good idea.
4 tasks
I agree, this looks desirable and compatible with the PR. |
Merged
rustyrussell
force-pushed
the
opt_shutdown_moreversions
branch
2 times, most recently
from
e127a2a to
42d6d79
Compare
rustyrussell
force-pushed
the
opt_shutdown_moreversions
branch
from
4f72856 to
4e32927
Compare
rustyrussell
changed the title
opt_shutdown_anysegwitoption_shutdown_anysegwit
6 tasks
niftynei
changed the title
option_shutdown_anysegwitoption_shutdown_anysegwit (Feature 26/27)
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
May 14, 2021
Opt-in to allow any future segwit script in shutdown as long as it complies with BIP 141 (see lightning/bolts#672).
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
May 14, 2021
Opt-in to allow any future segwit script in shutdown as long as it complies with BIP 141 (see lightning/bolts#672).
t-bast
approved these changes
May 14, 2021
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
May 17, 2021
Opt-in to allow any future segwit script in shutdown as long as it complies with BIP 141 (see lightning/bolts#672).
10 tasks
|
Applying as per action at meeting 2021-05-24. |
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
May 25, 2021
lightning/bolts#672 was merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: `option_shutdown_anysegwit` allows future segwit versions on shutdown transactions.
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
May 25, 2021
lightning/bolts#672 was merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: `option_shutdown_anysegwit` allows future segwit versions on shutdown transactions.
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
May 25, 2021
lightning/bolts#672 was merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: `option_shutdown_anysegwit` allows future segwit versions on shutdown transactions.
cdecker
pushed a commit
to rustyrussell/lightning
that referenced
this pull request
May 25, 2021
lightning/bolts#672 was merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: `option_shutdown_anysegwit` allows future segwit versions on shutdown transactions.
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
May 25, 2021
lightning/bolts#672 was merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: `option_shutdown_anysegwit` allows future segwit versions on shutdown transactions.
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
May 26, 2021
lightning/bolts#672 was merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: `option_shutdown_anysegwit` allows future segwit versions on shutdown transactions.
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
May 26, 2021
lightning/bolts#672 was merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: `option_shutdown_anysegwit` allows future segwit versions on shutdown transactions.
rustyrussell
added a commit
to ElementsProject/lightning
that referenced
this pull request
May 26, 2021
lightning/bolts#672 was merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: `option_shutdown_anysegwit` allows future segwit versions on shutdown transactions.
bitromortac
added a commit
to bitromortac/electrum
that referenced
this pull request
Oct 22, 2021
lightning/bolts#672 We check the received shutdown script against higher segwit versions and accept closing to that script if option_shutdown_anysegwit has been negotiated.
bitromortac
added a commit
to bitromortac/electrum
that referenced
this pull request
Oct 22, 2021
lightning/bolts#672 We check the received shutdown script against higher segwit versions and accept closing to that script if option_shutdown_anysegwit has been negotiated.
3 tasks
bitromortac
added a commit
to bitromortac/electrum
that referenced
this pull request
Oct 26, 2021
lightning/bolts#672 We check the received shutdown script against higher segwit versions and accept closing to that script if option_shutdown_anysegwit has been negotiated.
t-bast
added a commit
to ACINQ/lightning-kmp
that referenced
this pull request
Dec 9, 2021
Opt-in to allow any future segwit script in shutdown as long as it complies with BIP 141 (see lightning/bolts#672). This is particularly useful to allow wallet users to close channels to a Taproot address.
t-bast
added a commit
to ACINQ/lightning-kmp
that referenced
this pull request
Feb 7, 2022
Opt-in to allow any future segwit script in shutdown as long as it complies with BIP 141 (see lightning/bolts#672). This is particularly useful to allow wallet users to close channels to a Taproot address.
t-bast
added a commit
to ACINQ/lightning-kmp
that referenced
this pull request
Feb 7, 2022
Opt-in to allow any future segwit script in shutdown as long as it complies with BIP 141 (see lightning/bolts#672). This is particularly useful to allow wallet users to close channels to a Taproot address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bitcoin 0.19.0, standardness rules are going to be relaxed to allow
future witness versions. Once this is widely deployed, it will be safe
to accept them, smoothing use of future segwit versions.
See: bitcoin/bitcoin#15846
Signed-off-by: Rusty Russell [email protected]