Added a functional interface EventLoopSchedulerFactory#5323
Open
LaylaSilbernberg wants to merge 4 commits into
Open
Added a functional interface EventLoopSchedulerFactory#5323LaylaSilbernberg wants to merge 4 commits into
LaylaSilbernberg wants to merge 4 commits into
Conversation
LaylaSilbernberg
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
December 4, 2023 15:03
|
|
ikhoon
reviewed
Dec 20, 2023
| import java.util.function.ToIntFunction; | ||
|
|
||
| @FunctionalInterface | ||
| public interface EventLoopSchedulerFactory { |
Contributor
There was a problem hiding this comment.
Would you deprecate the following API and add a new API using this interface?
Author
There was a problem hiding this comment.
Ah! Yes, that should be no problem. What does the deprecation process look like?
Author
|
Modifications:
Result:
|
…cheduler-factory-branch # Conflicts: # core/src/main/java/com/linecorp/armeria/client/EventLoopSchedulerFactory.java
LaylaSilbernberg
force-pushed
the
event-loop-scheduler-factory-branch
branch
from
January 18, 2024 12:43
44eed76 to
4776e64
Compare
Author
|
Rolled things back, updated the project, added the changes. I don't know what happened that made the previous update so polluted. |
minwoox
reviewed
May 14, 2024
| @@ -0,0 +1,15 @@ | |||
| package com.linecorp.armeria.client; | |||
| public static final ClientFactoryOption<EventLoopGroup> WORKER_GROUP = | ||
| ClientFactoryOption.define("WORKER_GROUP", CommonPools.workerGroup()); | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Could you revert the changes in this file? It's hard to recognize which one is modified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Issue #5289 outlines how the current Event Loop Scheduler factory method may not be enough to create more sophisticated Event Loop Schedulers. I seek to address this by adding a more generalized factory method as requested.
Modifications:
Result:
EventLoopSchedulerFactory#5289