Skip to content

Added a functional interface EventLoopSchedulerFactory #5323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LaylaSilbernberg wants to merge 4 commits into
base: main
Choose a base branch
from
+608 −554
Open

Added a functional interface EventLoopSchedulerFactory #5323

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81af7b9
Added a functional interface EventLoopSchedulerFactory
LaylaSilbernberg Dec 4, 2023
f1ff6c6
added new event loop scheduler factory api, deprecated old api, clean…
LaylaSilbernberg Jan 18, 2024
af2f9d0
further cleanup
LaylaSilbernberg Jan 18, 2024
4776e64
Merge branch 'event-loop-scheduler-factory-cleanup' into event-loop-s…
LaylaSilbernberg Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions core/src/main/java/com/linecorp/armeria/client/EventLoopSchedulerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package com.linecorp.armeria.client;

@minwoox minwoox May 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing copyright


import io.netty.channel.EventLoopGroup;

import java.util.List;
import java.util.function.ToIntFunction;

@FunctionalInterface
public interface EventLoopSchedulerFactory {

@ikhoon ikhoon Dec 20, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you deprecate the following API and add a new API using this interface?

armeria/core/src/main/java/com/linecorp/armeria/client/ClientFactoryBuilder.java

Lines 162 to 163 in a8106e1

public ClientFactoryBuilder eventLoopSchedulerFactory(
Function<? super EventLoopGroup, ? extends EventLoopScheduler> eventLoopSchedulerFactory) {

@LaylaSilbernberg LaylaSilbernberg Dec 22, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Yes, that should be no problem. What does the deprecation process look like?

EventLoopScheduler newScheduler(EventLoopGroup eventLoopGroup,
List<ToIntFunction<Endpoint>> maxNumEventLoopFunctions,
int maxNumEventLoopsFunctions,
int maxNumEventLoopsPerHttp1Endpoint,
long idleTimeOutMillis);
}