This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
Make a new wayland backend using smithay-client-toolkit #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
reviewed
Jul 16, 2023
| loop_signal: LoopSignal, | ||
| pub(super) idle_sender: Sender<IdleAction>, | ||
| pub(super) loop_sender: channel::Sender<ActiveAction>, | ||
| pub(super) raw_display_handle: *mut c_void, |
There was a problem hiding this comment.
You could keep the Connection around for this or get the underlying Backend from wayland-backend and keep that.
There was a problem hiding this comment.
I would like to avoid random 'Application' instances keeping the connection alive(?) without reason, which it's possible that this would do.
But I'm not tied to this particular implementation decision
Merged
jaredoconnell
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Looks like a good start. This looks good to merge once PR #117 is merged.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous commit histories can be found in waylander and waylandest. Those histories were abandoned to rebase over #103, #104 and #105.
Works towards #28
Future work, which should probably be done before merge
Other future work, which can be collaborated on once merged:
OutputState, I thinkWhat do we actually use monitors for?