Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Move to Rust 1.71in CI #117

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Move to Rust 1.71in CI #117

merged 2 commits into from
Jul 20, 2023

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Jul 20, 2023

Semi-required #107

@waywardmonkeys
Copy link
Contributor

Is this just to be able to use Option::is_some_and ?

@DJMcNab
Copy link
Member Author

DJMcNab commented Jul 20, 2023

Broadly yes, although the policy (stated just above) is:

If the version specified here is no longer the latest stable version, then please feel free to submit a PR that adjusts it along with the potential clippy fixes.

That is, we need to update the CI anyway, so that may as happen done it when there's a desire for it. I don't think we document support for anything other than the latest stable.

Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think disabling the clippy check for Wayland until it's replaced is reasonable.

@DJMcNab DJMcNab added this pull request to the merge queue Jul 20, 2023
@xStrom
Copy link
Member

xStrom commented Jul 20, 2023

As for how this relates to MSRV - the CI variable isn't meant for MSRV tracking. As in Glazier doesn't currently follow an explicit MSRV. I think that should change (not as part of this PR, but in the future) - however primarily to have clear communication. Until we're shiping actual releases there's not a lot of motivation to keep MSRV lagging behind stable much.

Merged via the queue into linebender:main with commit 4bd4213 Jul 20, 2023
10 checks passed
@DJMcNab DJMcNab deleted the ci-1.71 branch July 20, 2023 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants