Add a pre-check step for creating INDIS connections #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohhyang
requested changes
Sep 3, 2025
| return; | ||
| } | ||
|
|
||
| if (!preCheckForIndisConnection()) |
Contributor
There was a problem hiding this comment.
The pre-check should be run only ONCE at startup, instead of in every startRpcStreamLocal (every reconnect). After #1093 is merged, there will be a start() method in XdsClientImpl, so you can add it there (cleaner).
Or add it to startRpcStream().
Contributor
There was a problem hiding this comment.
btw, this precheck shouldn't be run on the executor but should be blocking xds client startup, so that later we can control whether to fail the app startup if the precheck fails.
Collaborator
Author
There was a problem hiding this comment.
Yeah. I add some logic to make sure the precheck will only run one-time
PapaCharlie
requested changes
Sep 3, 2025
bohhyang
reviewed
Sep 17, 2025
bohhyang
approved these changes
Sep 18, 2025
PapaCharlie
requested changes
Sep 24, 2025
PapaCharlie
approved these changes
Sep 25, 2025
brycezhongqing
deleted the
zhonchen/add_pre_check_for_xds_connection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
During the INDIS migration, we observed that many clients encountered various issues when connecting to INDIS. Troubleshooting these problems often consumed significant time from both customers and the INDIS team.
This PR addresses that pain point by introducing a pre-check function that runs before attempting to establish an INDIS connection. The pre-check introduces no side effects—it will not alter or break the normal workflow. Instead, it provides clear log messages that indicate which errors might prevent a successful INDIS connection.
With these logs, customers and the INDIS team can more easily identify root causes, accelerating troubleshooting and enabling customers to resolve issues on their own.
🚨 Pre-Check Failure Scenarios
Java version too lowNetwork connectivity issuesgRPC health check failuresMissing dependenciesTest Done
[✅]manully test
case1: Everything goes well:
case2: NACL issue: